Issue 2278153005: CPDF_Annot::GetRect() should return CFX_FloatRect.

Issue 2278153005: CPDF_Annot::GetRect() should return CFX_FloatRect. (Closed)

Created:
4 years, 3 months ago by jaepark

Modified:
4 years, 3 months ago

Reviewers:
Lei Zhang, dsinclair

CC:
pdfium-reviews_googlegroups.com

Target Ref:
refs/heads/master

Project:
pdfium

Visibility:
Public.

CPDF_Annot::GetRect() should return CFX_FloatRect. Avoid using reference argument and return CFX_FloatRect instead. Committed: https://pdfium.googlesource.com/pdfium/+/a1d2111945acb35cb3403226e68a1920910fa23e

Created: 4 years, 3 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+19 lines, -35 lines)			Patch
M	core/fpdfdoc/cpdf_annot.cpp	View	3 chunks	+8 lines, -10 lines	0 comments	Download
M	core/fpdfdoc/cpdf_annotlist.cpp	View	1 chunk	+1 line, -2 lines	0 comments	Download
M	core/fpdfdoc/include/cpdf_annot.h	View	1 chunk	+1 line, -1 line	0 comments	Download
M	fpdfsdk/cba_annotiterator.cpp	View	1 chunk	+1 line, -3 lines	0 comments	Download
M	fpdfsdk/cpdfsdk_baannot.cpp	View	1 chunk	+1 line, -3 lines	0 comments	Download
M	fpdfsdk/cpdfsdk_widget.cpp	View	1 chunk	+1 line, -2 lines	0 comments	Download
M	fpdfsdk/formfiller/cffl_formfiller.cpp	View	2 chunks	+2 lines, -4 lines	0 comments	Download
M	fpdfsdk/formfiller/cffl_iformfiller.cpp	View	1 chunk	+1 line, -4 lines	0 comments	Download
M	fpdfsdk/fpdfeditpage.cpp	View	1 chunk	+1 line, -2 lines	0 comments	Download
M	fpdfsdk/fsdk_mgr.cpp	View	2 chunks	+2 lines, -4 lines	0 comments	Download

Total messages: 11 (7 generated)

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2278153005/1

4 years, 3 months ago (2016-08-25 20:33:19 UTC) #9

commit-bot: I haz the power

4 years, 3 months ago (2016-08-25 20:33:41 UTC) #11

Message was sent while issue was closed.

Committed patchset #1 (id:1) as
https://pdfium.googlesource.com/pdfium/+/a1d2111945acb35cb3403226e68a1920910f...