fpdfsdk/cpdfsdk_widget.cpp - Issue 2278153005: CPDF_Annot::GetRect() should return CFX_FloatRect.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: fpdfsdk/cpdfsdk_widget.cpp

Issue 2278153005: CPDF_Annot::GetRect() should return CFX_FloatRect. (Closed)

Patch Set: Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: fpdfsdk/cpdfsdk_widget.cpp

diff --git a/fpdfsdk/cpdfsdk_widget.cpp b/fpdfsdk/cpdfsdk_widget.cpp

index a36014c924f0dddf400b412dde1a066b506ea0be..dcccf0ce1aa1c1434e687f6726c7d44eb5c0cc15 100644

--- a/fpdfsdk/cpdfsdk_widget.cpp

+++ b/fpdfsdk/cpdfsdk_widget.cpp

@@ -1975,8 +1975,7 @@ int32_t CPDFSDK_Widget::GetValueAge() const {

FX_BOOL CPDFSDK_Widget::HitTest(FX_FLOAT pageX, FX_FLOAT pageY) {

CPDF_Annot* pAnnot = GetPDFAnnot();

- CFX_FloatRect annotRect;

- pAnnot->GetRect(annotRect);

+ CFX_FloatRect annotRect = pAnnot->GetRect();

if (!annotRect.Contains(pageX, pageY))

return FALSE;

« no previous file with comments | « fpdfsdk/cpdfsdk_baannot.cpp ('k') | fpdfsdk/formfiller/cffl_formfiller.cpp » ('j') | no next file with comments »