Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2278153003:
[Ignition] Add test of bytecode compilation on background thread. (Closed)
|
Created:
4 years, 3 months ago by rmcilroy Modified:
4 years, 3 months ago Reviewers:
jochen (gone - plz use gerrit) CC:
v8-reviews_googlegroups.com Base URL:
https://chromium.googlesource.com/v8/v8.git@master Target Ref:
refs/pending/heads/master Project:
v8 Visibility:
Public. |
Description[Ignition] Add test of bytecode compilation on background thread.
BUG=v8:5203
Committed: https://crrev.com/a550528dd2facea96ae0987f2d7acf001a55a382
Cr-Commit-Position: refs/heads/master@{#39207}
Patch Set 1 #Patch Set 2 : Fix nosnapshot #
Total comments: 6
Patch Set 3 : Address comments #Messages
Total messages: 31 (23 generated)
The CQ bit was checked by rmcilroy@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was checked by rmcilroy@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was checked by rmcilroy@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: v8_win_nosnap_shared_rel_ng on master.tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_win_nosnap_shared_rel_ng...) v8_win_nosnap_shared_rel_ng_triggered on master.tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_win_nosnap_shared_rel_ng...)
Patchset #3 (id:40001) has been deleted
Patchset #2 (id:20001) has been deleted
Patchset #2 (id:60001) has been deleted
Patchset #2 (id:80001) has been deleted
The CQ bit was checked by rmcilroy@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
rmcilroy@chromium.org changed reviewers: + jochen@chromium.org
PTAL, thanks.
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
https://codereview.chromium.org/2278153003/diff/100001/test/unittests/compile... File test/unittests/compiler-dispatcher/compiler-dispatcher-job-unittest.cc (right): https://codereview.chromium.org/2278153003/diff/100001/test/unittests/compile... test/unittests/compiler-dispatcher/compiler-dispatcher-job-unittest.cc:26: static void SetUpTestCase() { any reason you don't use the per-test case SetUp() and TearDown() virtual methods? https://codereview.chromium.org/2278153003/diff/100001/test/unittests/compile... test/unittests/compiler-dispatcher/compiler-dispatcher-job-unittest.cc:39: }; DISALLOW_COPY_AND_ASSIGN plz https://codereview.chromium.org/2278153003/diff/100001/test/unittests/compile... test/unittests/compiler-dispatcher/compiler-dispatcher-job-unittest.cc:274: }; disallow copy & assign and a virtual dtor please
https://codereview.chromium.org/2278153003/diff/100001/test/unittests/compile... File test/unittests/compiler-dispatcher/compiler-dispatcher-job-unittest.cc (right): https://codereview.chromium.org/2278153003/diff/100001/test/unittests/compile... test/unittests/compiler-dispatcher/compiler-dispatcher-job-unittest.cc:26: static void SetUpTestCase() { On 2016/08/26 15:05:48, jochen wrote: > any reason you don't use the per-test case SetUp() and TearDown() virtual > methods? We need to set the flag before we create the isolate. Since the Isolate is created in SetupTestCase we need to do this here. https://codereview.chromium.org/2278153003/diff/100001/test/unittests/compile... test/unittests/compiler-dispatcher/compiler-dispatcher-job-unittest.cc:39: }; On 2016/08/26 15:05:48, jochen wrote: > DISALLOW_COPY_AND_ASSIGN plz Done. https://codereview.chromium.org/2278153003/diff/100001/test/unittests/compile... test/unittests/compiler-dispatcher/compiler-dispatcher-job-unittest.cc:274: }; On 2016/08/26 15:05:48, jochen wrote: > disallow copy & assign and a virtual dtor please Done.
The CQ bit was checked by rmcilroy@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
Ping?
lgtm
The CQ bit was checked by rmcilroy@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Message was sent while issue was closed.
Committed patchset #3 (id:120001)
Message was sent while issue was closed.
Description was changed from ========== [Ignition] Add test of bytecode compilation on background thread. BUG=v8:5203 ========== to ========== [Ignition] Add test of bytecode compilation on background thread. BUG=v8:5203 Committed: https://crrev.com/a550528dd2facea96ae0987f2d7acf001a55a382 Cr-Commit-Position: refs/heads/master@{#39207} ==========
Message was sent while issue was closed.
Patchset 3 (id:??) landed as https://crrev.com/a550528dd2facea96ae0987f2d7acf001a55a382 Cr-Commit-Position: refs/heads/master@{#39207} |
