Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(262)

Unified Diff: test/unittests/compiler-dispatcher/compiler-dispatcher-job-unittest.cc

Issue 2278153003: [Ignition] Add test of bytecode compilation on background thread. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: Address comments Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: test/unittests/compiler-dispatcher/compiler-dispatcher-job-unittest.cc
diff --git a/test/unittests/compiler-dispatcher/compiler-dispatcher-job-unittest.cc b/test/unittests/compiler-dispatcher/compiler-dispatcher-job-unittest.cc
index e79d7234815e81fb2dc9161e01c0f78b65bb2392..584bf0f7d705c8a0c8d4b68bb144734de31211ec 100644
--- a/test/unittests/compiler-dispatcher/compiler-dispatcher-job-unittest.cc
+++ b/test/unittests/compiler-dispatcher/compiler-dispatcher-job-unittest.cc
@@ -7,10 +7,12 @@
#include "include/v8.h"
#include "src/api.h"
#include "src/ast/scopes.h"
+#include "src/base/platform/semaphore.h"
#include "src/compiler-dispatcher/compiler-dispatcher-job.h"
#include "src/flags.h"
#include "src/isolate-inl.h"
#include "src/parsing/parse-info.h"
+#include "src/v8.h"
#include "test/unittests/test-utils.h"
#include "testing/gtest/include/gtest/gtest.h"
@@ -19,6 +21,29 @@ namespace internal {
typedef TestWithContext CompilerDispatcherJobTest;
+class IgnitionCompilerDispatcherJobTest : public TestWithContext {
+ public:
+ IgnitionCompilerDispatcherJobTest() {}
+ ~IgnitionCompilerDispatcherJobTest() override {}
+
+ static void SetUpTestCase() {
+ old_flag_ = i::FLAG_ignition;
+ i::FLAG_ignition = true;
+ TestWithContext::SetUpTestCase();
+ }
+
+ static void TearDownTestCase() {
+ TestWithContext::TearDownTestCase();
+ i::FLAG_ignition = old_flag_;
+ }
+
+ private:
+ static bool old_flag_;
+ DISALLOW_COPY_AND_ASSIGN(IgnitionCompilerDispatcherJobTest);
+};
+
+bool IgnitionCompilerDispatcherJobTest::old_flag_;
+
namespace {
const char test_script[] = "(x) { x*x; }";
@@ -237,5 +262,52 @@ TEST_F(CompilerDispatcherJobTest, CompileFailureToFinalize) {
ASSERT_TRUE(job->status() == CompileJobStatus::kInitial);
}
+class CompileTask : public Task {
+ public:
+ CompileTask(CompilerDispatcherJob* job, base::Semaphore* semaphore)
+ : job_(job), semaphore_(semaphore) {}
+ ~CompileTask() override {}
+
+ void Run() override {
+ job_->Compile();
+ semaphore_->Signal();
+ }
+
+ private:
+ CompilerDispatcherJob* job_;
+ base::Semaphore* semaphore_;
+ DISALLOW_COPY_AND_ASSIGN(CompileTask);
+};
+
+TEST_F(IgnitionCompilerDispatcherJobTest, CompileOnBackgroundThread) {
+ const char* raw_script =
+ "(a, b) {\n"
+ " var c = a + b;\n"
+ " function bar() { return b }\n"
+ " var d = { foo: 100, bar : bar() }\n"
+ " return bar;"
+ "}";
+ ScriptResource script(raw_script, strlen(raw_script));
+ std::unique_ptr<CompilerDispatcherJob> job(new CompilerDispatcherJob(
+ i_isolate(), CreateFunction(i_isolate(), &script), 100));
+
+ job->PrepareToParseOnMainThread();
+ job->Parse();
+ job->FinalizeParsingOnMainThread();
+ job->PrepareToCompileOnMainThread();
+ ASSERT_TRUE(job->can_compile_on_background_thread());
+
+ base::Semaphore semaphore(0);
+ CompileTask* background_task = new CompileTask(job.get(), &semaphore);
+ V8::GetCurrentPlatform()->CallOnBackgroundThread(background_task,
+ Platform::kShortRunningTask);
+ semaphore.Wait();
+ ASSERT_TRUE(job->FinalizeCompilingOnMainThread());
+ ASSERT_TRUE(job->status() == CompileJobStatus::kDone);
+
+ job->ResetOnMainThread();
+ ASSERT_TRUE(job->status() == CompileJobStatus::kInitial);
+}
+
} // namespace internal
} // namespace v8
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698