Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(547)

Issue 2278123002: headless: Ensure all commands have parameters and return types (Closed)

Created:
4 years, 3 months ago by Sami
Modified:
4 years, 3 months ago
Reviewers:
altimin
CC:
chromium-reviews, pfeldman, devtools-reviews_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

headless: Ensure all commands have parameters and return types When generating C++ bindings, ensure all commands have a method which takes a full parameters object and returns a return value object. This ensures the API for experimental commands is retained even if that command is made stable. BUG=640919 Committed: https://crrev.com/6b9268d993ae9fb5bcb2ec21082ac5fe4ec82dc0 Cr-Commit-Position: refs/heads/master@{#414431}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+46 lines, -61 lines) Patch
M headless/lib/browser/client_api_generator.py View 2 chunks +10 lines, -4 lines 0 comments Download
M headless/lib/browser/client_api_generator_unittest.py View 3 chunks +2 lines, -32 lines 0 comments Download
M headless/lib/browser/domain_cc.template View 3 chunks +14 lines, -14 lines 0 comments Download
M headless/lib/browser/domain_h.template View 2 chunks +7 lines, -10 lines 0 comments Download
M headless/lib/headless_devtools_client_browsertest.cc View 2 chunks +13 lines, -1 line 0 comments Download

Messages

Total messages: 11 (5 generated)
Sami
4 years, 3 months ago (2016-08-25 13:24:31 UTC) #3
altimin
LGTM, great! Do you want to fix the problem with experimental params for a stable ...
4 years, 3 months ago (2016-08-25 13:36:25 UTC) #4
Sami
On 2016/08/25 13:36:25, altimin wrote: > LGTM, great! > > Do you want to fix ...
4 years, 3 months ago (2016-08-25 13:39:57 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2278123002/1
4 years, 3 months ago (2016-08-25 13:40:18 UTC) #7
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 3 months ago (2016-08-25 14:31:04 UTC) #9
commit-bot: I haz the power
4 years, 3 months ago (2016-08-25 14:32:39 UTC) #11
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/6b9268d993ae9fb5bcb2ec21082ac5fe4ec82dc0
Cr-Commit-Position: refs/heads/master@{#414431}

Powered by Google App Engine
This is Rietveld 408576698