headless: Ensure all commands have parameters and return types

headless/lib/headless_devtools_client_browsertest.cc

 // Copyright 2016 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include <memory>
 
 #include "base/json/json_reader.h"
 #include "content/public/browser/render_widget_host_view.h"
 #include "content/public/browser/web_contents.h"
 #include "content/public/test/browser_test.h"
@@ skipping 174 matching lines @@
   void RunDevTooledTest() override {
     EXPECT_TRUE(embedded_test_server()->Start());
     // Check that experimental commands require parameter objects.
     devtools_client_->GetRuntime()
         ->GetExperimental()
         ->SetCustomObjectFormatterEnabled(
             runtime::SetCustomObjectFormatterEnabledParams::Builder()
                 .SetEnabled(false)
                 .Build());
 
+    // Check that a previously experimental command which takes no parameters
+    // still works by giving it a parameter object.
+    devtools_client_->GetRuntime()->GetExperimental()->RunIfWaitingForDebugger(
+        runtime::RunIfWaitingForDebuggerParams::Builder().Build());
+
     devtools_client_->GetPage()->GetExperimental()->AddObserver(this);
     devtools_client_->GetPage()->Enable();
     devtools_client_->GetPage()->Navigate(
         embedded_test_server()->GetURL("/hello.html").spec());
   }
 
   void OnFrameStoppedLoading(
       const page::FrameStoppedLoadingParams& params) override {
-    FinishAsynchronousTest();
+    // Check that a non-experimental command which has no return value can be
+    // called with a void() callback.
+    devtools_client_->GetPage()->Reload(
+        page::ReloadParams::Builder().Build(),
+        base::Bind(&HeadlessDevToolsClientExperimentalTest::OnReloadStarted,
+                   base::Unretained(this)));
   }
+
+  void OnReloadStarted() { FinishAsynchronousTest(); }
 };
 
 HEADLESS_ASYNC_DEVTOOLED_TEST_F(HeadlessDevToolsClientExperimentalTest);
 
 class BrowserDomainCreateAndDeletePageTest
     : public HeadlessAsyncDevTooledBrowserTest {
   void RunDevTooledTest() override {
     EXPECT_TRUE(embedded_test_server()->Start());
 
     EXPECT_EQ(1u, GetAllWebContents(browser()).size());
@@ skipping 420 matching lines @@
     FinishAsynchronousTest();
   }
 
  private:
   bool navigation_requested_ = false;
 };
 
 HEADLESS_ASYNC_DEVTOOLED_TEST_F(HeadlessDevToolsNavigationControlTest);
 
 }  // namespace headless