Reland [Presubmit tests] Warn when new source files are not added to GN/GYPi files.

Reland [Presubmit tests] Warn when new source files are not added to GN/GYPi files.

Add a presubmit check that warns when new source files are
not added to GN or gypi files. Check is done on upload only before gni includes are fixed.

BUG=112371
Committed: https://crrev.com/1efc2f5f650a355056a98b6c99d4d0260742a750
Cr-Commit-Position: refs/heads/master@{#414975}

[maksims (do not use this acc), 2016-08-25 20:09:30]

Description was changed from

==========
a

BUG=
==========

to

==========
Reland [Presubmit tests] Warn when new source files are not added to GN/GYPi
files.

Add a presubmit check that warns when new source files are
not added to GN or gypi files. Check is done on upload only before gni includes
are fixed.

BUG=112371
==========

[maksims (do not use this acc), 2016-08-25 20:09:30]

maksim.sisov@intel.com changed reviewers:
+ dpranke@chromium.org

[maksims (do not use this acc), 2016-08-25 20:09:38]

The CQ bit was checked by maksim.sisov@intel.com to run a CQ dry run

[maksims (do not use this acc), 2016-08-25 20:09:43]

ptal

[commit-bot: I haz the power, 2016-08-25 20:10:53]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-25 20:49:26]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-25 20:49:27]

Dry run: This issue passed the CQ dry run.

[Dirk Pranke, 2016-08-26 00:51:23]

lgtm, but let's wait until next week (after the Chrome M54 branch point, which
is today some time) to land this.

[maksims (do not use this acc), 2016-08-29 04:43:26]

The CQ bit was checked by maksim.sisov@intel.com

[commit-bot: I haz the power, 2016-08-29 04:43:49]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-29 05:27:04]

Description was changed from

==========
Reland [Presubmit tests] Warn when new source files are not added to GN/GYPi
files.

Add a presubmit check that warns when new source files are
not added to GN or gypi files. Check is done on upload only before gni includes
are fixed.

BUG=112371
==========

to

==========
Reland [Presubmit tests] Warn when new source files are not added to GN/GYPi
files.

Add a presubmit check that warns when new source files are
not added to GN or gypi files. Check is done on upload only before gni includes
are fixed.

BUG=112371
==========

[commit-bot: I haz the power, 2016-08-29 05:27:05]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2016-08-29 05:29:08]

Description was changed from

==========
Reland [Presubmit tests] Warn when new source files are not added to GN/GYPi
files.

Add a presubmit check that warns when new source files are
not added to GN or gypi files. Check is done on upload only before gni includes
are fixed.

BUG=112371
==========

to

==========
Reland [Presubmit tests] Warn when new source files are not added to GN/GYPi
files.

Add a presubmit check that warns when new source files are
not added to GN or gypi files. Check is done on upload only before gni includes
are fixed.

BUG=112371

Committed: https://crrev.com/1efc2f5f650a355056a98b6c99d4d0260742a750
Cr-Commit-Position: refs/heads/master@{#414975}
==========

[commit-bot: I haz the power, 2016-08-29 05:29:09]

Patchset 1 (id:??) landed as
https://crrev.com/1efc2f5f650a355056a98b6c99d4d0260742a750
Cr-Commit-Position: refs/heads/master@{#414975}

[sky, 2016-08-30 03:33:07]

A revert of this CL (patchset #1 id:1) has been created in
https://codereview.chromium.org/2293763002/ by sky@chromium.org.

The reason for reverting is: This causes warning if files are referenced in gyp
file. https://codereview.chromium.org/2285703003/ triggered presubmit when it
shouln't have..

[sky, 2016-08-30 03:41:42]

On 2016/08/30 03:33:07, sky wrote:
> A revert of this CL (patchset #1 id:1) has been created in
> https://codereview.chromium.org/2293763002/ by mailto:sky@chromium.org.
> 
> The reason for reverting is: This causes warning if files are referenced in
gyp
> file. https://codereview.chromium.org/2285703003/ triggered presubmit when it
> shouln't have..

Please do not attempt to land this until there is more discussion of whether we
want this feature. IMO there are valid reasons for a source to not to exist in a
gyp/gypi file that would trigger this presubmit.