Reland [Presubmit tests] Warn when new source files are not added to GN/GYPi files.

PRESUBMIT.py

 # Copyright (c) 2012 The Chromium Authors. All rights reserved.
 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file.
 
 """Top-level presubmit script for Chromium.
 
 See http://dev.chromium.org/developers/how-tos/depottools/presubmit-scripts
 for more details about the presubmit API built into depot_tools.
 """
 
@@ skipping 1928 matching lines @@
 
 
 def _AndroidSpecificOnUploadChecks(input_api, output_api):
   """Groups checks that target android code."""
   results = []
   results.extend(_CheckAndroidCrLogUsage(input_api, output_api))
   results.extend(_CheckAndroidNewMdpiAssetLocation(input_api, output_api))
   results.extend(_CheckAndroidToastUsage(input_api, output_api))
   return results
 
+def _CheckNewSourceFileAddedToGnGypi(input_api, output_api):
+   """Checks new source code files were added to GN/GYPi files"""
+   new_source_files = []
+   gn_gypi_files = []
+
+   """ Get lists of new source code files and GN/GYPi files in the commit"""
+   for f in input_api.AffectedFiles():
+     if f.LocalPath().endswith(('.gn', '.gypi')):
+       gn_gypi_files.append(f)
+       continue
+     if f.LocalPath().endswith(('.h', '.c', '.cc', '.m', '.mm', '.java')):
+        if f.Action() == 'A':
+          new_source_files.append(f.LocalPath())
+
+   if not new_source_files:
+     return []
+
+   if not gn_gypi_files:
+     return [output_api.PresubmitPromptWarning('The following new'
+         ' source code files must be added to GN/GYPI files:\n    ' +
+         '\n    '.join(new_source_files))]
+
+   """Get a list of new source code files that CAN BE FOUND in the GN/GYPI
+      files"""
+   source_files_listed = []
+   for f in new_source_files:
+     head, sep, tail = f.rpartition('/')
+     source_file_match_pattern = tail
+     for g in gn_gypi_files:
+       for line in g.GenerateScmDiff().splitlines():
+         if line.endswith((source_file_match_pattern + '",',
+                           source_file_match_pattern + '\',')):
+           source_files_listed.append(f)
+           break
+
+   """Remove files, which has been found in the GN files, from the list"""
+   for f in source_files_listed:
+     if f in new_source_files:
+       new_source_files.remove(f)
+
+   if new_source_files:
+     return [output_api.PresubmitPromptWarning('The following new'
+         ' source code files must be added to GN/GYPI files:\n    ' +
+         '\n    '.join(new_source_files))]
+
+   return []
 
 def _CommonChecks(input_api, output_api):
   """Checks common to both upload and commit."""
   results = []
   results.extend(input_api.canned_checks.PanProjectChecks(
       input_api, output_api,
       excluded_paths=_EXCLUDED_PATHS + _TESTRUNNER_PATHS))
   results.extend(_CheckAuthorizedAuthor(input_api, output_api))
   results.extend(
       _CheckNoProductionCodeUsingTestOnlyFunctions(input_api, output_api))
@@ skipping 242 matching lines @@
 
 
 def CheckChangeOnUpload(input_api, output_api):
   results = []
   results.extend(_CommonChecks(input_api, output_api))
   results.extend(_CheckValidHostsInDEPS(input_api, output_api))
   results.extend(
       input_api.canned_checks.CheckGNFormatted(input_api, output_api))
   results.extend(_CheckUmaHistogramChanges(input_api, output_api))
   results.extend(_AndroidSpecificOnUploadChecks(input_api, output_api))
+  results.extend(_CheckNewSourceFileAddedToGnGypi(input_api, output_api))
   return results
 
 
 def GetTryServerMasterForBot(bot):
   """Returns the Try Server master for the given bot.
 
   It tries to guess the master from the bot name, but may still fail
   and return None.  There is no longer a default master.
   """
   # Potentially ambiguous bot names are listed explicitly.
@@ skipping 34 matching lines @@
   results.extend(input_api.canned_checks.CheckTreeIsOpen(
       input_api,
       output_api,
       json_url='http://chromium-status.appspot.com/current?format=json'))
 
   results.extend(input_api.canned_checks.CheckChangeHasBugField(
       input_api, output_api))
   results.extend(input_api.canned_checks.CheckChangeHasDescription(
       input_api, output_api))
   return results