Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(149)

Issue 2278093003: Set the 3 times suppress threshold for the smart password bubble. (Closed)

Created:
4 years, 3 months ago by vasilii
Modified:
4 years, 3 months ago
Reviewers:
vabr (Chromium)
CC:
chromium-reviews, gcasto+watchlist_chromium.org, vabr+watchlistpasswordmanager_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Set the 3 times suppress threshold for the smart password bubble. This is essentially launching the smart password bubble unless the server config overwrites the value. BUG=618312 Committed: https://crrev.com/db85689d5859b3a9b48af9eb71845d1d054557f0 Cr-Commit-Position: refs/heads/master@{#414412}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -1 line) Patch
M components/password_manager/core/browser/password_bubble_experiment.cc View 1 chunk +2 lines, -1 line 0 comments Download

Messages

Total messages: 15 (8 generated)
vasilii
Hi Vaclav, please review.
4 years, 3 months ago (2016-08-25 11:36:58 UTC) #5
vabr (Chromium)
LGTM, happy to see this launching!
4 years, 3 months ago (2016-08-25 11:48:33 UTC) #6
vabr (Chromium)
Actually, we should clean-up files like testing/variations/fieldtrial_testing_config_mac.json
4 years, 3 months ago (2016-08-25 11:49:58 UTC) #7
vasilii
On 2016/08/25 11:49:58, vabr (Chromium) wrote: > Actually, we should clean-up files like > testing/variations/fieldtrial_testing_config_mac.json ...
4 years, 3 months ago (2016-08-25 11:53:44 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2278093003/1
4 years, 3 months ago (2016-08-25 11:54:02 UTC) #11
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 3 months ago (2016-08-25 13:03:15 UTC) #13
commit-bot: I haz the power
4 years, 3 months ago (2016-08-25 13:05:23 UTC) #15
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/db85689d5859b3a9b48af9eb71845d1d054557f0
Cr-Commit-Position: refs/heads/master@{#414412}

Powered by Google App Engine
This is Rietveld 408576698