Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(408)

Unified Diff: components/password_manager/core/browser/password_bubble_experiment.cc

Issue 2278093003: Set the 3 times suppress threshold for the smart password bubble. (Closed)
Patch Set: Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: components/password_manager/core/browser/password_bubble_experiment.cc
diff --git a/components/password_manager/core/browser/password_bubble_experiment.cc b/components/password_manager/core/browser/password_bubble_experiment.cc
index 0339782f312352ef5bddea3cfb2f148b89fa806a..4a5b6f5fa7c46b14fb4cc7b17a23441da738cafd 100644
--- a/components/password_manager/core/browser/password_bubble_experiment.cc
+++ b/components/password_manager/core/browser/password_bubble_experiment.cc
@@ -46,7 +46,8 @@ int GetSmartBubbleDismissalThreshold() {
std::string param = variations::GetVariationParamValue(
kSmartBubbleExperimentName, kSmartBubbleThresholdParam);
int threshold = 0;
- return base::StringToInt(param, &threshold) ? threshold : 0;
+ // 3 is the default magic number that proved to show the best result.
+ return base::StringToInt(param, &threshold) ? threshold : 3;
}
bool IsSmartLockUser(const sync_driver::SyncService* sync_service) {
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698