Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(134)

Issue 2277893003: Re-enable LayoutTable{Cell,Row}DeathTest.* on non-Mac (Closed)

Created:
4 years, 4 months ago by dgrogan
Modified:
4 years, 4 months ago
Reviewers:
eae
CC:
chromium-reviews, szager+layoutwatch_chromium.org, zoltan1, blink-reviews-layout_chromium.org, pdr+renderingwatchlist_chromium.org, eae+blinkwatch, leviw+renderwatch, jchaffraix+rendering, blink-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Re-enable LayoutTable{Cell,Row}DeathTest.* on non-Mac They only flake on mac_chromium_rel_ng. I couldn't reproduce locally. BUG=632816 Committed: https://crrev.com/999f2f8ad6a65f52d6ad3e36b8ab03224b7af5d4 Cr-Commit-Position: refs/heads/master@{#414166}

Patch Set 1 #

Patch Set 2 : Re-enable LayoutTable{Cell,Row}DeathTest.* on non-mac #

Unified diffs Side-by-side diffs Delta from patch set Stats (+14 lines, -12 lines) Patch
M third_party/WebKit/Source/core/layout/LayoutTableCellTest.cpp View 1 2 chunks +7 lines, -6 lines 0 comments Download
M third_party/WebKit/Source/core/layout/LayoutTableRowTest.cpp View 1 2 chunks +7 lines, -6 lines 0 comments Download

Messages

Total messages: 9 (4 generated)
dgrogan
4 years, 4 months ago (2016-08-24 20:26:47 UTC) #3
eae
LGTM
4 years, 4 months ago (2016-08-24 20:29:37 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2277893003/20001
4 years, 4 months ago (2016-08-24 20:33:03 UTC) #6
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 4 months ago (2016-08-24 22:06:15 UTC) #7
commit-bot: I haz the power
4 years, 4 months ago (2016-08-24 22:10:22 UTC) #9
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/999f2f8ad6a65f52d6ad3e36b8ab03224b7af5d4
Cr-Commit-Position: refs/heads/master@{#414166}

Powered by Google App Engine
This is Rietveld 408576698