| OLD | NEW |
| 1 /* | 1 /* |
| 2 * Copyright (C) 2012 Google Inc. All rights reserved. | 2 * Copyright (C) 2012 Google Inc. All rights reserved. |
| 3 * | 3 * |
| 4 * Redistribution and use in source and binary forms, with or without | 4 * Redistribution and use in source and binary forms, with or without |
| 5 * modification, are permitted provided that the following conditions | 5 * modification, are permitted provided that the following conditions |
| 6 * are met: | 6 * are met: |
| 7 * | 7 * |
| 8 * 1. Redistributions of source code must retain the above copyright | 8 * 1. Redistributions of source code must retain the above copyright |
| 9 * notice, this list of conditions and the following disclaimer. | 9 * notice, this list of conditions and the following disclaimer. |
| 10 * 2. Redistributions in binary form must reproduce the above copyright | 10 * 2. Redistributions in binary form must reproduce the above copyright |
| (...skipping 29 matching lines...) Expand all Loading... |
| 40 } | 40 } |
| 41 | 41 |
| 42 virtual void TearDown() | 42 virtual void TearDown() |
| 43 { | 43 { |
| 44 m_row->destroy(); | 44 m_row->destroy(); |
| 45 } | 45 } |
| 46 | 46 |
| 47 LayoutTableRow* m_row; | 47 LayoutTableRow* m_row; |
| 48 }; | 48 }; |
| 49 | 49 |
| 50 // TODO(esprehn): Disabled all of these tests because they're flaky: crbug.com/6
30625 | 50 TEST_F(LayoutTableRowDeathTest, CanSetRow) |
| 51 TEST_F(LayoutTableRowDeathTest, DISABLED_CanSetRow) | |
| 52 { | 51 { |
| 53 static const unsigned rowIndex = 10; | 52 static const unsigned rowIndex = 10; |
| 54 m_row->setRowIndex(rowIndex); | 53 m_row->setRowIndex(rowIndex); |
| 55 EXPECT_EQ(rowIndex, m_row->rowIndex()); | 54 EXPECT_EQ(rowIndex, m_row->rowIndex()); |
| 56 } | 55 } |
| 57 | 56 |
| 58 TEST_F(LayoutTableRowDeathTest, DISABLED_CanSetRowToMaxRowIndex) | 57 TEST_F(LayoutTableRowDeathTest, CanSetRowToMaxRowIndex) |
| 59 { | 58 { |
| 60 m_row->setRowIndex(maxRowIndex); | 59 m_row->setRowIndex(maxRowIndex); |
| 61 EXPECT_EQ(maxRowIndex, m_row->rowIndex()); | 60 EXPECT_EQ(maxRowIndex, m_row->rowIndex()); |
| 62 } | 61 } |
| 63 | 62 |
| 64 // FIXME: Re-enable these tests once ASSERT_DEATH is supported for Android. | 63 // FIXME: Re-enable these tests once ASSERT_DEATH is supported for Android. |
| 65 // See: https://bugs.webkit.org/show_bug.cgi?id=74089 | 64 // See: https://bugs.webkit.org/show_bug.cgi?id=74089 |
| 66 #if !OS(ANDROID) | 65 // TODO(dgrogan): These tests started flaking on Mac try bots around 2016-07-28. |
| 66 // https://crbug.com/632816 |
| 67 #if !OS(ANDROID) && !OS(MACOSX) |
| 67 | 68 |
| 68 TEST_F(LayoutTableRowDeathTest, DISABLED_CrashIfRowOverflowOnSetting) | 69 TEST_F(LayoutTableRowDeathTest, CrashIfRowOverflowOnSetting) |
| 69 { | 70 { |
| 70 ASSERT_DEATH(m_row->setRowIndex(maxRowIndex + 1), ""); | 71 ASSERT_DEATH(m_row->setRowIndex(maxRowIndex + 1), ""); |
| 71 } | 72 } |
| 72 | 73 |
| 73 TEST_F(LayoutTableRowDeathTest, DISABLED_CrashIfSettingUnsetRowIndex) | 74 TEST_F(LayoutTableRowDeathTest, CrashIfSettingUnsetRowIndex) |
| 74 { | 75 { |
| 75 ASSERT_DEATH(m_row->setRowIndex(unsetRowIndex), ""); | 76 ASSERT_DEATH(m_row->setRowIndex(unsetRowIndex), ""); |
| 76 } | 77 } |
| 77 | 78 |
| 78 #endif | 79 #endif |
| 79 | 80 |
| 80 using LayoutTableRowTest = RenderingTest; | 81 using LayoutTableRowTest = RenderingTest; |
| 81 | 82 |
| 82 TEST_F(LayoutTableRowTest, BackgroundIsKnownToBeOpaqueWithLayerAndCollapsedBorde
r) | 83 TEST_F(LayoutTableRowTest, BackgroundIsKnownToBeOpaqueWithLayerAndCollapsedBorde
r) |
| 83 { | 84 { |
| (...skipping 22 matching lines...) Expand all Loading... |
| 106 "<tr style='background-color: blue'><td>Cell</td><td>Cell</td></tr>" | 107 "<tr style='background-color: blue'><td>Cell</td><td>Cell</td></tr>" |
| 107 "</table>"); | 108 "</table>"); |
| 108 | 109 |
| 109 LayoutTableRow* row = toLayoutTableRow(document().body()->firstChild()->firs
tChild()->firstChild()->layoutObject()); | 110 LayoutTableRow* row = toLayoutTableRow(document().body()->firstChild()->firs
tChild()->firstChild()->layoutObject()); |
| 110 EXPECT_FALSE(row->backgroundIsKnownToBeOpaqueInRect(LayoutRect(0, 0, 1, 1)))
; | 111 EXPECT_FALSE(row->backgroundIsKnownToBeOpaqueInRect(LayoutRect(0, 0, 1, 1)))
; |
| 111 } | 112 } |
| 112 | 113 |
| 113 } // anonymous namespace | 114 } // anonymous namespace |
| 114 | 115 |
| 115 } // namespace blink | 116 } // namespace blink |
| OLD | NEW |