Rename CustomElementsRegistry to CustomElementRegistry

Rename CustomElementsRegistry to CustomElementRegistry

The spec was changed for discussion at github issue:
https://github.com/w3c/webcomponents/issues/548

BUG=640236
Committed: https://crrev.com/dc135bf34d9b3f70abc44a98fec9ef03f2b52f88
Cr-Commit-Position: refs/heads/master@{#414326}

[kochi, 2016-08-24 11:26:37]

The CQ bit was checked by kochi@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-08-24 11:26:56]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-24 14:38:53]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-24 14:38:54]

Dry run: This issue passed the CQ dry run.

[kochi, 2016-08-24 15:33:16]

Description was changed from

==========
Rename CustomElementsRegistry to CustomElementRegistry


BUG=640236
==========

to

==========
Rename CustomElementsRegistry to CustomElementRegistry


BUG=640236
==========

[kochi, 2016-08-24 15:33:16]

kochi@chromium.org changed reviewers:
+ kojii@chromium.org

[kochi, 2016-08-24 15:33:58]

PTAL

[kochi, 2016-08-24 15:34:11]

The CQ bit was checked by kochi@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-08-24 15:35:01]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-24 17:15:50]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-24 17:15:51]

Dry run: Try jobs failed on following builders:
  linux_android_rel_ng on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/linux_androi...)

[kojii, 2016-08-25 02:00:13]

kojii@chromium.org changed reviewers:
+ tkent@chromium.org

[kojii, 2016-08-25 02:00:14]

LGTM, great thank you for doing this.

tkent@, PTAL.

[bashi, 2016-08-25 02:03:44]

bashi@chromium.org changed reviewers:
+ bashi@chromium.org

[bashi, 2016-08-25 02:03:44]

bindings/ lgtm

[tkent, 2016-08-25 02:08:05]

Web-exposed change lgtm.  This interface is not shipped yet.

> Rename CustomElementsRegistry to CustomElementRegistry

Adding a rationale to the CL description would be helpful.  Maybe it was changed
in the specification?

[kochi, 2016-08-25 02:17:35]

Description was changed from

==========
Rename CustomElementsRegistry to CustomElementRegistry


BUG=640236
==========

to

==========
Rename CustomElementsRegistry to CustomElementRegistry

The spec was changed for discussion at github issue:
https://github.com/w3c/webcomponents/issues/548

BUG=640236
==========

[kochi, 2016-08-25 02:18:52]

On 2016/08/25 02:08:05, tkent wrote:
> Web-exposed change lgtm.  This interface is not shipped yet.
> 
> > Rename CustomElementsRegistry to CustomElementRegistry
> 
> Adding a rationale to the CL description would be helpful.  Maybe it was
changed
> in the specification?

Thanks for pointing it out.  Updated the description.

[kochi, 2016-08-25 02:21:08]

The CQ bit was checked by kochi@chromium.org

[commit-bot: I haz the power, 2016-08-25 02:22:26]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-25 03:11:12]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-25 03:11:13]

Failed to apply patch for
third_party/WebKit/Source/core/dom/custom/CustomElement.cpp:
While running git apply --index -3 -p1;
  error: patch failed:
third_party/WebKit/Source/core/dom/custom/CustomElement.cpp:20
  Falling back to three-way merge...
  Applied patch to 'third_party/WebKit/Source/core/dom/custom/CustomElement.cpp'
with conflicts.
  U third_party/WebKit/Source/core/dom/custom/CustomElement.cpp

Patch:       third_party/WebKit/Source/core/dom/custom/CustomElement.cpp
Index: third_party/WebKit/Source/core/dom/custom/CustomElement.cpp
diff --git a/third_party/WebKit/Source/core/dom/custom/CustomElement.cpp
b/third_party/WebKit/Source/core/dom/custom/CustomElement.cpp
index
f5d1b2084259d210e062bf6553be983a8d4a5af4..b4acfb51cd90cea8a5c78c9959647da2391b9593
100644
--- a/third_party/WebKit/Source/core/dom/custom/CustomElement.cpp
+++ b/third_party/WebKit/Source/core/dom/custom/CustomElement.cpp
@@ -9,7 +9,7 @@
 #include "core/dom/custom/CEReactionsScope.h"
 #include "core/dom/custom/CustomElementDefinition.h"
 #include "core/dom/custom/CustomElementReactionStack.h"
-#include "core/dom/custom/CustomElementsRegistry.h"
+#include "core/dom/custom/CustomElementRegistry.h"
 #include "core/dom/custom/V0CustomElement.h"
 #include "core/dom/custom/V0CustomElementRegistrationContext.h"
 #include "core/frame/LocalDOMWindow.h"
@@ -20,11 +20,11 @@
 
 namespace blink {
 
-CustomElementsRegistry* CustomElement::registry(const Element& element)
+CustomElementRegistry* CustomElement::registry(const Element& element)
 {
     return registry(element.document());
 }
-CustomElementsRegistry* CustomElement::registry(const Document& document)
+CustomElementRegistry* CustomElement::registry(const Document& document)
 {
     if (LocalDOMWindow* window = document.domWindow())
         return window->customElements();
@@ -92,7 +92,7 @@ bool CustomElement::shouldCreateCustomElement(const
QualifiedName& tagName)
 
 static CustomElementDefinition* definitionForName(const Document& document,
const QualifiedName& name)
 {
-    if (CustomElementsRegistry* registry = CustomElement::registry(document))
+    if (CustomElementRegistry* registry = CustomElement::registry(document))
         return registry->definitionForName(name.localName());
     return nullptr;
 }
@@ -237,7 +237,7 @@ void CustomElement::tryToUpgrade(Element* element)
 
     DCHECK_EQ(element->getCustomElementState(), CustomElementState::Undefined);
 
-    CustomElementsRegistry* registry = CustomElement::registry(*element);
+    CustomElementRegistry* registry = CustomElement::registry(*element);
     if (!registry)
         return;
     if (CustomElementDefinition* definition =
registry->definitionForName(element->localName()))

[kochi, 2016-08-25 03:28:14]

The CQ bit was checked by kochi@chromium.org

[kochi, 2016-08-25 03:28:14]

The patchset sent to the CQ was uploaded after l-g-t-m from tkent@chromium.org,
kojii@chromium.org, bashi@chromium.org
Link to the patchset: https://codereview.chromium.org/2277713002/#ps40001
(title: "rebase")

[commit-bot: I haz the power, 2016-08-25 03:28:53]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-25 05:38:12]

Description was changed from

==========
Rename CustomElementsRegistry to CustomElementRegistry

The spec was changed for discussion at github issue:
https://github.com/w3c/webcomponents/issues/548

BUG=640236
==========

to

==========
Rename CustomElementsRegistry to CustomElementRegistry

The spec was changed for discussion at github issue:
https://github.com/w3c/webcomponents/issues/548

BUG=640236
==========

[commit-bot: I haz the power, 2016-08-25 05:38:13]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2016-08-25 05:39:57]

Description was changed from

==========
Rename CustomElementsRegistry to CustomElementRegistry

The spec was changed for discussion at github issue:
https://github.com/w3c/webcomponents/issues/548

BUG=640236
==========

to

==========
Rename CustomElementsRegistry to CustomElementRegistry

The spec was changed for discussion at github issue:
https://github.com/w3c/webcomponents/issues/548

BUG=640236

Committed: https://crrev.com/dc135bf34d9b3f70abc44a98fec9ef03f2b52f88
Cr-Commit-Position: refs/heads/master@{#414326}
==========

[commit-bot: I haz the power, 2016-08-25 05:39:58]

Patchset 3 (id:??) landed as
https://crrev.com/dc135bf34d9b3f70abc44a98fec9ef03f2b52f88
Cr-Commit-Position: refs/heads/master@{#414326}