third_party/WebKit/Source/core/dom/custom/README.md - Issue 2277713002: Rename CustomElementsRegistry to CustomElementRegistry

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/dom/custom/README.md

Issue 2277713002: Rename CustomElementsRegistry to CustomElementRegistry (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: rebase Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/core/dom/custom/CustomElementsRegistryTest.cpp ('k') | third_party/WebKit/Source/core/dom/custom/V0CustomElementRegistrationContext.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/dom/custom/README.md

diff --git a/third_party/WebKit/Source/core/dom/custom/README.md b/third_party/WebKit/Source/core/dom/custom/README.md

index 5d7f387bec4546340b26a952aa05109303968097..f10d4218fc2e0910bf0195bb1ce74c7cb3336ed6 100644

--- a/third_party/WebKit/Source/core/dom/custom/README.md

+++ b/third_party/WebKit/Source/core/dom/custom/README.md

@@ -25,7 +25,7 @@ moment there is only one: ScriptCustomElementDefinition.

ScriptCustomElementDefinition is linked to its constructor by an ID

number. The ID number is stored in a map, keyed by constructor, in a

-hidden value of the CustomElementsRegistry wrapper. The ID is an index

+hidden value of the CustomElementRegistry wrapper. The ID is an index

into a list of definitions stored in V8PerContextData.

###### CustomElementDescriptor

@@ -36,7 +36,7 @@ these strings will be different. In that case, the local name is the

element's tag name and the custom element name is related to the value

of the “is” attribute.

-###### CustomElementsRegistry

+###### CustomElementRegistry

Implements the `window.customElements` property. This maintains the

set of registered names. The wrapper of this object is used by

@@ -56,7 +56,7 @@ kept around indefinitely because they could be created in future by

the parser. On the other hand, we must not leak when a window can no

longer run script.

-We use a V8HiddenValue on the CustomElementsRegistry wrapper which

+We use a V8HiddenValue on the CustomElementRegistry wrapper which

points to a map that keeps constructors and prototypes alive. See

ScriptCustomElementDefinition.

@@ -65,9 +65,7 @@ ScriptCustomElementDefinition.

In comments and prose, write custom elements, not Custom Elements, to

match the HTML standard.

-Prefix type names with CustomElement (singular). The one exception to

-this rule is CustomElementsRegistry, which uses a plural to match the

-name of the interface in the specification.

+Prefix type names with CustomElement (singular).

## Testing