Implement tex{Sub}Image{2|3}D with ArrayBufferView sub source.

Implement tex{Sub}Image{2|3}D with ArrayBufferView sub source.

BUG=639145
TEST=https://github.com/KhronosGroup/WebGL/pull/1982
R=kbr@chromium.org,tkent@chromium.org,haraken@chromium.org
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel

Committed: https://crrev.com/46768c6c985640e066946771aef2301e35f316f9
Cr-Commit-Position: refs/heads/master@{#414323}

[Zhenyao Mo, 2016-08-24 22:07:23]

Description was changed from

==========
Implement tex{Sub}Image{2|3}D with ArrayBufferView sub source.

BUG=639145
TEST=https://github.com/KhronosGroup/WebGL/pull/1982
R=kbr@chromium.org,tkent@chromium.org,haraken@chromium.org
==========

to

==========
Implement tex{Sub}Image{2|3}D with ArrayBufferView sub source.

BUG=639145
TEST=https://github.com/KhronosGroup/WebGL/pull/1982
R=kbr@chromium.org,tkent@chromium.org,haraken@chromium.org
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel
==========

[Zhenyao Mo, 2016-08-24 22:09:39]

kbr: PTAL.
karaken,tkent: wtf owner review.

Test is here: https://github.com/KhronosGroup/WebGL/pull/1982

[Zhenyao Mo, 2016-08-24 22:09:44]

The CQ bit was checked by zmo@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-08-24 22:10:33]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Ken Russell (switch to Gerrit), 2016-08-25 01:29:23]

Looks perfect. LGTM

[tkent, 2016-08-25 01:52:41]

core and wtf lgtm

https://codereview.chromium.org/2277603005/diff/1/third_party/WebKit/Source/m...
File third_party/WebKit/Source/modules/webgl/WebGLRenderingContextBase.cpp
(right):

https://codereview.chromium.org/2277603005/diff/1/third_party/WebKit/Source/m...
third_party/WebKit/Source/modules/webgl/WebGLRenderingContextBase.cpp:5684:
DCHECK(disposition != NullNotReachable);
DCHECK_NE(disposition, NullNotReachable)

[haraken, 2016-08-25 01:54:20]

LGTM

[Zhenyao Mo, 2016-08-25 01:59:12]

https://codereview.chromium.org/2277603005/diff/1/third_party/WebKit/Source/m...
File third_party/WebKit/Source/modules/webgl/WebGLRenderingContextBase.cpp
(right):

https://codereview.chromium.org/2277603005/diff/1/third_party/WebKit/Source/m...
third_party/WebKit/Source/modules/webgl/WebGLRenderingContextBase.cpp:5684:
DCHECK(disposition != NullNotReachable);
On 2016/08/25 01:52:40, tkent wrote:
> DCHECK_NE(disposition, NullNotReachable)

Done.

[Zhenyao Mo, 2016-08-25 01:59:17]

The CQ bit was checked by zmo@chromium.org

[Zhenyao Mo, 2016-08-25 01:59:18]

The patchset sent to the CQ was uploaded after l-g-t-m from tkent@chromium.org,
haraken@chromium.org, kbr@chromium.org
Link to the patchset: https://codereview.chromium.org/2277603005/#ps20001
(title: "tiny improvement")

[commit-bot: I haz the power, 2016-08-25 02:00:00]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-25 03:02:15]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-25 03:02:17]

Try jobs failed on following builders:
  mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

[Zhenyao Mo, 2016-08-25 03:25:32]

The CQ bit was checked by zmo@chromium.org

[commit-bot: I haz the power, 2016-08-25 03:26:16]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-25 05:35:13]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-08-25 05:37:28]

Description was changed from

==========
Implement tex{Sub}Image{2|3}D with ArrayBufferView sub source.

BUG=639145
TEST=https://github.com/KhronosGroup/WebGL/pull/1982
R=kbr@chromium.org,tkent@chromium.org,haraken@chromium.org
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel
==========

to

==========
Implement tex{Sub}Image{2|3}D with ArrayBufferView sub source.

BUG=639145
TEST=https://github.com/KhronosGroup/WebGL/pull/1982
R=kbr@chromium.org,tkent@chromium.org,haraken@chromium.org
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel

Committed: https://crrev.com/46768c6c985640e066946771aef2301e35f316f9
Cr-Commit-Position: refs/heads/master@{#414323}
==========

[commit-bot: I haz the power, 2016-08-25 05:37:29]

Patchset 2 (id:??) landed as
https://crrev.com/46768c6c985640e066946771aef2301e35f316f9
Cr-Commit-Position: refs/heads/master@{#414323}