Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1609)

Issue 2277583002: Add pixel tests for rastering painted scrollbars at different scales. (Closed)

Created:
4 years, 4 months ago by danakj
Modified:
4 years, 4 months ago
Reviewers:
enne (OOO)
CC:
cc-bugs_chromium.org, chromium-reviews, piman
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Add pixel tests for rastering painted scrollbars at different scales. R=enne BUG=606056 CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_precise_blink_rel Committed: https://crrev.com/d63f8a6f411250c40ad77a5ba5713f51b5c45cbe Cr-Commit-Position: refs/heads/master@{#413969}

Patch Set 1 #

Patch Set 2 : scrollbarpixeltests: fixbaseline #

Patch Set 3 : scrollbarpixeltests: fix-racey-crashing #

Unified diffs Side-by-side diffs Delta from patch set Stats (+174 lines, -0 lines) Patch
M cc/BUILD.gn View 1 chunk +1 line, -0 lines 0 comments Download
A cc/test/data/spiral_64_scale.png View 1 Binary file 0 comments Download
A cc/test/data/spiral_double_scale.png View Binary file 0 comments Download
A cc/trees/layer_tree_host_pixeltest_scrollbars.cc View 1 2 1 chunk +173 lines, -0 lines 0 comments Download

Dependent Patchsets:

Messages

Total messages: 19 (13 generated)
danakj
4 years, 4 months ago (2016-08-24 00:00:54 UTC) #3
danakj
The super big scale might need some per-platform fuzziness, let the try bots decide.
4 years, 4 months ago (2016-08-24 00:01:15 UTC) #4
enne (OOO)
lgtm
4 years, 4 months ago (2016-08-24 00:44:18 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2277583002/40001
4 years, 4 months ago (2016-08-24 02:15:26 UTC) #16
commit-bot: I haz the power
Committed patchset #3 (id:40001)
4 years, 4 months ago (2016-08-24 03:27:05 UTC) #17
commit-bot: I haz the power
4 years, 4 months ago (2016-08-24 03:31:43 UTC) #19
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/d63f8a6f411250c40ad77a5ba5713f51b5c45cbe
Cr-Commit-Position: refs/heads/master@{#413969}

Powered by Google App Engine
This is Rietveld 408576698