ui/views/mus/native_widget_mus.cc - Issue 2277563002: Wires up immersive mode for chrome and mash

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: ui/views/mus/native_widget_mus.cc

Issue 2277563002: Wires up immersive mode for chrome and mash (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: fix crash Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: ui/views/mus/native_widget_mus.cc

diff --git a/ui/views/mus/native_widget_mus.cc b/ui/views/mus/native_widget_mus.cc

index c98fa9069cae6021d5ddbccf1c0f4f39080412aa..3e8db2f7a3395fd320a3589b38b8b4b2273e9661 100644

--- a/ui/views/mus/native_widget_mus.cc

+++ b/ui/views/mus/native_widget_mus.cc

@@ -1083,7 +1083,7 @@ void NativeWidgetMus::SetFullscreen(bool fullscreen) {

return;

if (fullscreen) {

show_state_before_fullscreen_ = GetShowState(window_);

- // TODO(markdittmer): Fullscreen not implemented in ui::Window.

+ SetShowState(ui::mojom::ShowState::FULLSCREEN);

} else {

switch (show_state_before_fullscreen_) {

case ui::mojom::ShowState::MAXIMIZED: