Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1715)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: services/ui/ws/window_tree.cc

Issue 2277563002: Wires up immersive mode for chrome and mash (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: fix crash Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« services/ui/ws/window_manager_state.cc ('K') | « services/ui/ws/window_manager_state.cc ('k') | ui/views/mus/native_widget_mus.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: services/ui/ws/window_tree.cc
diff --git a/services/ui/ws/window_tree.cc b/services/ui/ws/window_tree.cc
index 7780d57fe07600d53bc4349aea0e04805ad1d170..1841ffee0ca8a83d009cc303e5cd7f72f46a07c8 100644
--- a/services/ui/ws/window_tree.cc
+++ b/services/ui/ws/window_tree.cc
@@ -1292,8 +1292,10 @@ void WindowTree::AttachSurface(Id transport_window_id,
GetWindowByClientId(ClientWindowId(transport_window_id));
const bool success =
window && access_policy_->CanSetWindowSurface(window, type);
- if (!success)
+ if (!success) {
+ DVLOG(1) << "request to AttachSurface failed";
return;
+ }
window->CreateSurface(type, std::move(surface), std::move(client));
}
« services/ui/ws/window_manager_state.cc ('K') | « services/ui/ws/window_manager_state.cc ('k') | ui/views/mus/native_widget_mus.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698