Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(202)

Unified Diff: services/ui/ws/window_manager_access_policy.cc

Issue 2277563002: Wires up immersive mode for chrome and mash (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: fix crash Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: services/ui/ws/window_manager_access_policy.cc
diff --git a/services/ui/ws/window_manager_access_policy.cc b/services/ui/ws/window_manager_access_policy.cc
index 816d8996423009c86f29e29238b83964d74212f3..c815de54cb40ba3b4f22fa18849ead768e967e3e 100644
--- a/services/ui/ws/window_manager_access_policy.cc
+++ b/services/ui/ws/window_manager_access_policy.cc
@@ -89,11 +89,15 @@ bool WindowManagerAccessPolicy::CanChangeWindowOpacity(
bool WindowManagerAccessPolicy::CanSetWindowSurface(
const ServerWindow* window,
ui::mojom::SurfaceType surface_type) const {
+ // Allow the window manager to always provide the underlay. This is important
+ // when the window manager is asked to paint the title area to windows it did
+ // not create.
if (surface_type == mojom::SurfaceType::UNDERLAY)
- return WasCreatedByThisClient(window);
+ return true;
if (delegate_->IsWindowRootOfAnotherTreeForAccessPolicy(window))
return false;
+
return WasCreatedByThisClient(window) ||
(delegate_->HasRootForAccessPolicy(window));
}

Powered by Google App Engine
This is Rietveld 408576698