Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(125)

Issue 2234103002: New md circle icon for shelf launcher button (Closed)

Created:
4 years, 4 months ago by Greg Levin
Modified:
4 years, 4 months ago
Reviewers:
oshima
CC:
chromium-reviews, kalyank, sadrul
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

New md circle icon for shelf launcher button BUG=635558 TEST=Log in, observe Android circle instead of magnifying glass for shelf launcher button icon. Committed: https://crrev.com/d43817e513d9409425c86850428d66a13dfbf7bf Cr-Commit-Position: refs/heads/master@{#411324}

Patch Set 1 #

Messages

Total messages: 8 (3 generated)
Greg Levin
Please have a look! Screenshots with new icons are at https://bugs.chromium.org/p/chromium/issues/detail?id=635558#c11
4 years, 4 months ago (2016-08-10 21:56:59 UTC) #2
oshima
lgtm
4 years, 4 months ago (2016-08-11 08:18:56 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2234103002/1
4 years, 4 months ago (2016-08-11 13:55:19 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 4 months ago (2016-08-11 14:33:20 UTC) #6
commit-bot: I haz the power
4 years, 4 months ago (2016-08-11 14:34:50 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/d43817e513d9409425c86850428d66a13dfbf7bf
Cr-Commit-Position: refs/heads/master@{#411324}

Powered by Google App Engine
This is Rietveld 408576698