Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(28)

Issue 2277513003: [api] Improve documentation for NamedPropertyGetterCallback. (Closed)

Created:
4 years, 4 months ago by Franzi
Modified:
4 years, 3 months ago
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@DocCallbacksSetter
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[api] Improve documentation for NamedPropertyGetterCallback. BUG=v8:5260 Committed: https://crrev.com/97118fb5043bb78c8c5ae818eee77518d65b3a90 Cr-Commit-Position: refs/heads/master@{#38951}

Patch Set 1 #

Patch Set 2 : [api] Improve documentation for NamedPropertyGetterCallback. #

Patch Set 3 : Remove comment about empty handle. #

Patch Set 4 : Rewording comment. #

Patch Set 5 : Do not change documentation on soon to be deprecated function. #

Patch Set 6 : Rebase. #

Total comments: 1

Patch Set 7 : Word comment to set instead of change. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+34 lines, -2 lines) Patch
M include/v8.h View 1 2 3 4 5 6 1 chunk +34 lines, -2 lines 0 comments Download

Depends on Patchset:

Messages

Total messages: 9 (4 generated)
Franzi
Hi Jochen, here's the next piece of documentation, for PropertyGetterCallback. Please take a look. Thanks, ...
4 years, 3 months ago (2016-08-25 14:17:41 UTC) #2
jochen (gone - plz use gerrit)
lgtm with nit https://codereview.chromium.org/2277513003/diff/100001/include/v8.h File include/v8.h (right): https://codereview.chromium.org/2277513003/diff/100001/include/v8.h#newcode4346 include/v8.h:4346: * Use `info.GetReturnValue().Set()` to change the ...
4 years, 3 months ago (2016-08-25 14:22:43 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2277513003/110001
4 years, 3 months ago (2016-08-26 16:49:30 UTC) #6
commit-bot: I haz the power
Committed patchset #7 (id:110001)
4 years, 3 months ago (2016-08-26 17:13:59 UTC) #7
commit-bot: I haz the power
4 years, 3 months ago (2016-08-26 17:14:23 UTC) #9
Message was sent while issue was closed.
Patchset 7 (id:??) landed as
https://crrev.com/97118fb5043bb78c8c5ae818eee77518d65b3a90
Cr-Commit-Position: refs/heads/master@{#38951}

Powered by Google App Engine
This is Rietveld 408576698