Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(674)

Issue 2269053002: [api] Improve documentation for NamedPropertySetterCallback. (Closed)

Created:
4 years, 4 months ago by Franzi
Modified:
4 years, 3 months ago
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@DocPropertyCallbackInfo
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[api] Improve documentation for NamedPropertySetterCallback. BUG=v8:5260 Committed: https://crrev.com/260d0f1c197579218cded0d21d9efe26150a76bb Cr-Commit-Position: refs/heads/master@{#38950}

Patch Set 1 #

Patch Set 2 : Fix formatting. #

Patch Set 3 : Remove wrong sentence about Holder(). #

Total comments: 1

Patch Set 4 : Remove sentence about empty handle. #

Patch Set 5 : Do not change documentation on soon to be deprecated function. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+19 lines, -3 lines) Patch
M include/v8.h View 1 2 3 4 1 chunk +19 lines, -3 lines 0 comments Download

Depends on Patchset:

Dependent Patchsets:

Messages

Total messages: 13 (7 generated)
Franzi
More documentation changes. PTAL. Thanks, Franzi
4 years, 4 months ago (2016-08-23 12:37:04 UTC) #2
jochen (gone - plz use gerrit)
lgtm without the empty handle thing https://codereview.chromium.org/2269053002/diff/40001/include/v8.h File include/v8.h (right): https://codereview.chromium.org/2269053002/diff/40001/include/v8.h#newcode4307 include/v8.h:4307: * an empty ...
4 years, 4 months ago (2016-08-24 21:01:03 UTC) #3
commit-bot: I haz the power
This CL has an open dependency (Issue 2263303003 Patch 120001). Please resolve the dependency and ...
4 years, 4 months ago (2016-08-25 03:38:12 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2269053002/80001
4 years, 3 months ago (2016-08-26 16:20:28 UTC) #10
commit-bot: I haz the power
Committed patchset #5 (id:80001)
4 years, 3 months ago (2016-08-26 16:48:04 UTC) #11
commit-bot: I haz the power
4 years, 3 months ago (2016-08-26 16:49:08 UTC) #13
Message was sent while issue was closed.
Patchset 5 (id:??) landed as
https://crrev.com/260d0f1c197579218cded0d21d9efe26150a76bb
Cr-Commit-Position: refs/heads/master@{#38950}

Powered by Google App Engine
This is Rietveld 408576698