Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(55)

Issue 227743006: Revert 262147 "Remove all uses of GG_LONGLONG and GG_ULONGLONG." (Closed)

Created:
6 years, 8 months ago by scottmg
Modified:
6 years, 8 months ago
Reviewers:
viettrungluu
CC:
chromium-reviews
Visibility:
Public.

Description

Revert 262147 "Remove all uses of GG_LONGLONG and GG_ULONGLONG." Failed win compile: http://build.chromium.org/p/chromium/buildstatus?builder=Win&number=20266 > Remove all uses of GG_LONGLONG and GG_ULONGLONG. > > 123LL and 123ULL now work everywhere. You can also use INT64_C and > UINT64_C (from <stdint.h>) in Chromium code (we force-define > __STDC_CONSTANT_MACROS). (And sometimes you can just use > static_cast<(u)int64_t>.) > > Don't remove their definitions yet, because some macros that are > multiply-defined (in an identical way) rely on them. D'oh. > > R=brettw@chromium.org > TBR=sky@chromium.org,satorux@chromium.org,vrk@chromium.org,rch@chromium.org,shess@chromium.org > > Review URL: https://codereview.chromium.org/218953003 TBR=viettrungluu@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=262165

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+41 lines, -39 lines) Patch
M trunk/src/base/allocator/allocator_unittest.cc View 5 chunks +5 lines, -5 lines 0 comments Download
M trunk/src/base/atomicops_unittest.cc View 5 chunks +5 lines, -5 lines 0 comments Download
M trunk/src/base/basictypes.h View 1 chunk +3 lines, -3 lines 0 comments Download
M trunk/src/base/port.h View 1 chunk +0 lines, -4 lines 0 comments Download
M trunk/src/chrome/browser/chromeos/drive/file_system_unittest.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M trunk/src/chrome/browser/devtools/adb/android_rsa.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M trunk/src/chrome/browser/safe_browsing/safe_browsing_store_file.cc View 1 chunk +1 line, -1 line 0 comments Download
M trunk/src/content/browser/speech/google_streaming_remote_engine.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M trunk/src/google_apis/drive/gdata_wapi_parser_unittest.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M trunk/src/media/filters/chunk_demuxer_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M trunk/src/media/formats/webm/webm_constants.h View 1 chunk +1 line, -1 line 0 comments Download
M trunk/src/net/base/int128.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M trunk/src/net/base/int128_unittest.cc View 1 chunk +12 lines, -6 lines 0 comments Download
M trunk/src/sql/meta_table_unittest.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M trunk/src/ui/events/gestures/velocity_calculator_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 3 (0 generated)
scottmg
6 years, 8 months ago (2014-04-07 18:34:33 UTC) #1
scottmg
Committed patchset #1 manually as r262165 (tree was closed).
6 years, 8 months ago (2014-04-07 18:35:13 UTC) #2
scottmg
6 years, 8 months ago (2014-04-07 18:35:33 UTC) #3
Message was sent while issue was closed.

          

Powered by Google App Engine
This is Rietveld 408576698