Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(626)

Issue 218953003: Remove all uses of GG_LONGLONG and GG_ULONGLONG. (Closed)

Created:
6 years, 8 months ago by viettrungluu
Modified:
6 years, 8 months ago
CC:
chromium-reviews, cbentzel+watch_chromium.org, vsevik, nkostylev+watch_chromium.org, tfarina, jam, yurys, aandrey+blink_chromium.org, feature-media-reviews_chromium.org, paulirish+reviews_chromium.org, darin-cc_chromium.org, dmikurube+memory_chromium.org, oshima+watch_chromium.org, devtools-reviews_chromium.org, erikwright+watch_chromium.org, stevenjb+watch_chromium.org, pfeldman, davemoore+watch_chromium.org
Visibility:
Public.

Description

Remove all uses of GG_LONGLONG and GG_ULONGLONG. 123LL and 123ULL now work everywhere. You can also use INT64_C and UINT64_C (from <stdint.h>) in Chromium code (we force-define __STDC_CONSTANT_MACROS). (And sometimes you can just use static_cast<(u)int64_t>.) Don't remove their definitions yet, because some macros that are multiply-defined (in an identical way) rely on them. D'oh. R=brettw@chromium.org TBR=sky@chromium.org,satorux@chromium.org,vrk@chromium.org,rch@chromium.org,shess@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=262147 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=262294

Patch Set 1 #

Patch Set 2 : oops #

Patch Set 3 : rebased, undid base/port.h removal #

Patch Set 4 : fix win? #

Unified diffs Side-by-side diffs Delta from patch set Stats (+38 lines, -41 lines) Patch
M base/allocator/allocator_unittest.cc View 1 2 3 5 chunks +4 lines, -5 lines 0 comments Download
M base/atomicops_unittest.cc View 1 5 chunks +5 lines, -5 lines 0 comments Download
M base/basictypes.h View 1 chunk +3 lines, -3 lines 0 comments Download
M base/port.h View 1 2 1 chunk +4 lines, -0 lines 0 comments Download
M chrome/browser/chromeos/drive/file_system_unittest.cc View 1 2 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/devtools/adb/android_rsa.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/safe_browsing/safe_browsing_store_file.cc View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M content/browser/speech/google_streaming_remote_engine.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M google_apis/drive/gdata_wapi_parser_unittest.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M media/filters/chunk_demuxer_unittest.cc View 1 2 1 chunk +1 line, -1 line 0 comments Download
M media/formats/webm/webm_constants.h View 1 chunk +1 line, -1 line 0 comments Download
M net/base/int128.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M net/base/int128_unittest.cc View 1 chunk +6 lines, -12 lines 0 comments Download
M sql/meta_table_unittest.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M ui/events/gestures/velocity_calculator_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 14 (0 generated)
viettrungluu
6 years, 8 months ago (2014-04-05 06:51:36 UTC) #1
brettw
lgtm
6 years, 8 months ago (2014-04-06 03:23:18 UTC) #2
viettrungluu
OWNERS TBRs: sky (chrome/ and ui/) satorux (google_apis/drive/) vrk (media/) rch (net/) shess (sql/)
6 years, 8 months ago (2014-04-07 14:54:22 UTC) #3
viettrungluu
The CQ bit was checked by viettrungluu@chromium.org
6 years, 8 months ago (2014-04-07 14:54:30 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/viettrungluu@chromium.org/218953003/40001
6 years, 8 months ago (2014-04-07 14:54:38 UTC) #5
Scott Hess - ex-Googler
LGTM, realizing I needed this hack made me sad.
6 years, 8 months ago (2014-04-07 17:12:03 UTC) #6
commit-bot: I haz the power
Change committed as 262147
6 years, 8 months ago (2014-04-07 17:35:15 UTC) #7
Ryan Hamilton
net/ lgtm
6 years, 8 months ago (2014-04-07 17:36:32 UTC) #8
viettrungluu
FFFFFFFFFFFFFFUUUUUUUUUUUUUUUUUUUUU. Reverted r262165 (https://codereview.chromium.org/227743006), despite CQ landing it.
6 years, 8 months ago (2014-04-08 00:26:58 UTC) #9
viettrungluu
The CQ bit was checked by viettrungluu@chromium.org
6 years, 8 months ago (2014-04-08 00:31:47 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/viettrungluu@chromium.org/218953003/60001
6 years, 8 months ago (2014-04-08 00:31:50 UTC) #11
scottmg
On 2014/04/08 00:31:50, I haz the power (commit-bot) wrote: > CQ is trying da patch. ...
6 years, 8 months ago (2014-04-08 00:58:03 UTC) #12
scottmg
On 2014/04/08 00:58:03, scottmg wrote: > On 2014/04/08 00:31:50, I haz the power (commit-bot) wrote: ...
6 years, 8 months ago (2014-04-08 00:58:28 UTC) #13
commit-bot: I haz the power
6 years, 8 months ago (2014-04-08 04:00:40 UTC) #14
Message was sent while issue was closed.
Change committed as 262294

Powered by Google App Engine
This is Rietveld 408576698