src/builtins/builtins-object.cc - Issue 2277363002: [stubs] Consolidate TryToName implementation

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/builtins/builtins-object.cc

Issue 2277363002: [stubs] Consolidate TryToName implementation (Closed)

Patch Set: reword comment Created 4 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: src/builtins/builtins-object.cc

diff --git a/src/builtins/builtins-object.cc b/src/builtins/builtins-object.cc

index c422145a51801214090e87c74e73d63a32f2850c..918eb7ef5c4119518449137a2beff7d458afc4b4 100644

--- a/src/builtins/builtins-object.cc

+++ b/src/builtins/builtins-object.cc

@@ -35,7 +35,7 @@ void Builtins::Generate_ObjectHasOwnProperty(CodeStubAssembler* assembler) {

Node* map = assembler->LoadMap(object);

Node* instance_type = assembler->LoadMapInstanceType(map);

- Variable var_index(assembler, MachineRepresentation::kWord32);

+ Variable var_index(assembler, MachineType::PointerRepresentation());

Label keyisindex(assembler), if_iskeyunique(assembler);

assembler->TryToName(key, &keyisindex, &var_index, &if_iskeyunique,

« no previous file with comments | « no previous file | src/code-stub-assembler.h » ('j') | no next file with comments »