Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(957)

Side by Side Diff: src/builtins/builtins-object.cc

Issue 2277363002: [stubs] Consolidate TryToName implementation (Closed)
Patch Set: reword comment Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | src/code-stub-assembler.h » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2016 the V8 project authors. All rights reserved. 1 // Copyright 2016 the V8 project authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "src/builtins/builtins.h" 5 #include "src/builtins/builtins.h"
6 #include "src/builtins/builtins-utils.h" 6 #include "src/builtins/builtins-utils.h"
7 7
8 #include "src/code-factory.h" 8 #include "src/code-factory.h"
9 #include "src/property-descriptor.h" 9 #include "src/property-descriptor.h"
10 10
(...skipping 17 matching lines...) Expand all
28 28
29 // Smi receivers do not have own properties. 29 // Smi receivers do not have own properties.
30 Label if_objectisnotsmi(assembler); 30 Label if_objectisnotsmi(assembler);
31 assembler->Branch(assembler->WordIsSmi(object), &return_false, 31 assembler->Branch(assembler->WordIsSmi(object), &return_false,
32 &if_objectisnotsmi); 32 &if_objectisnotsmi);
33 assembler->Bind(&if_objectisnotsmi); 33 assembler->Bind(&if_objectisnotsmi);
34 34
35 Node* map = assembler->LoadMap(object); 35 Node* map = assembler->LoadMap(object);
36 Node* instance_type = assembler->LoadMapInstanceType(map); 36 Node* instance_type = assembler->LoadMapInstanceType(map);
37 37
38 Variable var_index(assembler, MachineRepresentation::kWord32); 38 Variable var_index(assembler, MachineType::PointerRepresentation());
39 39
40 Label keyisindex(assembler), if_iskeyunique(assembler); 40 Label keyisindex(assembler), if_iskeyunique(assembler);
41 assembler->TryToName(key, &keyisindex, &var_index, &if_iskeyunique, 41 assembler->TryToName(key, &keyisindex, &var_index, &if_iskeyunique,
42 &call_runtime); 42 &call_runtime);
43 43
44 assembler->Bind(&if_iskeyunique); 44 assembler->Bind(&if_iskeyunique);
45 assembler->TryHasOwnProperty(object, map, instance_type, key, &return_true, 45 assembler->TryHasOwnProperty(object, map, instance_type, key, &return_true,
46 &return_false, &call_runtime); 46 &return_false, &call_runtime);
47 47
48 assembler->Bind(&keyisindex); 48 assembler->Bind(&keyisindex);
(...skipping 856 matching lines...) Expand 10 before | Expand all | Expand 10 after
905 if (object->IsJSReceiver()) { 905 if (object->IsJSReceiver()) {
906 MAYBE_RETURN(JSReceiver::SetIntegrityLevel(Handle<JSReceiver>::cast(object), 906 MAYBE_RETURN(JSReceiver::SetIntegrityLevel(Handle<JSReceiver>::cast(object),
907 SEALED, Object::THROW_ON_ERROR), 907 SEALED, Object::THROW_ON_ERROR),
908 isolate->heap()->exception()); 908 isolate->heap()->exception());
909 } 909 }
910 return *object; 910 return *object;
911 } 911 }
912 912
913 } // namespace internal 913 } // namespace internal
914 } // namespace v8 914 } // namespace v8
OLDNEW
« no previous file with comments | « no previous file | src/code-stub-assembler.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698