Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(713)

Issue 2277323003: Revert of Support server categories in NTPSnippetsService. (Closed)

Created:
4 years, 3 months ago by johnme
Modified:
4 years, 3 months ago
CC:
chromium-reviews, ntp-dev+reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Support server categories in NTPSnippetsService. (patchset #13 id:240001 of https://codereview.chromium.org/2255783002/ ) Reason for revert: Following tests failing: NTPSnippetsServiceTest.GetDismissed NTPSnippetsServiceTest.LogNumArticlesHistogram NTPSnippetsServiceTest.DismissShouldRespectAllKnownUrls NTPSnippetsServiceTest.ImageReturnedWithTheSameId NTPSnippetsServiceTest.Dismiss on bots: https://build.chromium.org/p/chromium.linux/builders/Linux%20Tests/builds/45385 https://build.chromium.org/p/chromium.mac/builders/Mac10.9%20Tests/builds/27331 https://build.chromium.org/p/chromium.win/builders/Win%207%20Tests%20x64%20%281%29/builds/16271 Original issue's description: > Support server categories in NTPSnippetsService. > > BUG=633613 > > Committed: https://crrev.com/330958ddcdcd0084d724571eddaa66f9c364115f > Cr-Commit-Position: refs/heads/master@{#414443} TBR=treib@chromium.org,tschumann@chromium.org,sfiera@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=633613 Committed: https://crrev.com/afbca52da7667f2527fc6d68d502706ded561e14 Cr-Commit-Position: refs/heads/master@{#414455}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+272 lines, -461 lines) Patch
M components/ntp_snippets/ntp_snippets_fetcher.cc View 1 chunk +0 lines, -1 line 0 comments Download
M components/ntp_snippets/ntp_snippets_service.h View 6 chunks +21 lines, -37 lines 0 comments Download
M components/ntp_snippets/ntp_snippets_service.cc View 21 chunks +178 lines, -348 lines 0 comments Download
M components/ntp_snippets/ntp_snippets_service_unittest.cc View 21 chunks +73 lines, -75 lines 0 comments Download

Messages

Total messages: 7 (3 generated)
johnme
Created Revert of Support server categories in NTPSnippetsService.
4 years, 3 months ago (2016-08-25 16:38:47 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2277323003/1
4 years, 3 months ago (2016-08-25 16:39:33 UTC) #3
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 3 months ago (2016-08-25 16:40:23 UTC) #5
commit-bot: I haz the power
4 years, 3 months ago (2016-08-25 16:42:19 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/afbca52da7667f2527fc6d68d502706ded561e14
Cr-Commit-Position: refs/heads/master@{#414455}

Powered by Google App Engine
This is Rietveld 408576698