[fuchsia] Fix process launching. Update statuses.

[fuchsia] Fix process launching. Update statuses.

R=asiva@google.com, mcgrathr@chromium.org

Committed: https://github.com/dart-lang/sdk/commit/6963e6f4402bef04739fd44eedfaa889ce7af68f

[zra, 2016-08-25 16:13:29]

zra@google.com changed reviewers:
+ asiva@google.com, mcgrathr@google.com

[zra, 2016-08-25 16:13:30]

@mcgrathr, could you PTAL at the launchpad use here? Thanks!

[siva, 2016-08-25 18:02:10]

lgtm

https://codereview.chromium.org/2277313002/diff/80001/runtime/bin/run_vm_test...
File runtime/bin/run_vm_tests_fuchsia.cc (right):

https://codereview.chromium.org/2277313002/diff/80001/runtime/bin/run_vm_test...
runtime/bin/run_vm_tests_fuchsia.cc:103: // Bugs to fix, or things that are not
yet impelemnted.
implemented

[zra, 2016-08-25 18:14:14]

https://codereview.chromium.org/2277313002/diff/80001/runtime/bin/run_vm_test...
File runtime/bin/run_vm_tests_fuchsia.cc (right):

https://codereview.chromium.org/2277313002/diff/80001/runtime/bin/run_vm_test...
runtime/bin/run_vm_tests_fuchsia.cc:103: // Bugs to fix, or things that are not
yet impelemnted.
On 2016/08/25 18:02:10, siva wrote:
> implemented

Done.

[Roland McGrath, 2016-08-25 18:52:52]

mcgrathr@chromium.org changed reviewers:
+ mcgrathr@chromium.org

[Roland McGrath, 2016-08-25 18:52:52]

LGTM for launchpad use.  You're using the fine-grained launchpad functions just
to avoid inheriting all fds, right?
If you'd like to propose a change to the API of convenience functions (e.g.
adding another one, or changing launchpad_launch_mxio_etc to take a flag or
something) rather than your code having to keep up with every detail like this,
that would certainly be fine.

[zra, 2016-08-25 19:51:53]

On 2016/08/25 18:52:52, Roland McGrath wrote:
> LGTM for launchpad use.  You're using the fine-grained launchpad functions
just
> to avoid inheriting all fds, right?
> If you'd like to propose a change to the API of convenience functions (e.g.
> adding another one, or changing launchpad_launch_mxio_etc to take a flag or
> something) rather than your code having to keep up with every detail like
this,
> that would certainly be fine.

Thanks. Yah, for the fds, and to avoid doing launchpad_vmo_from_file() over and
over on the same binary.

[zra, 2016-08-25 19:57:13]

Description was changed from

==========
[fuchsia] Fix process launching. Update statuses.
==========

to

==========
[fuchsia] Fix process launching. Update statuses.

R=asiva@google.com, mcgrathr@chromium.org

Committed:
https://github.com/dart-lang/sdk/commit/6963e6f4402bef04739fd44eedfaa889ce7af68f
==========

[zra, 2016-08-25 19:57:19]

Committed patchset #6 (id:100001) manually as
6963e6f4402bef04739fd44eedfaa889ce7af68f (presubmit successful).