[fuchsia] Fix process launching. Update statuses.

runtime/bin/run_vm_tests_fuchsia.cc

 // Copyright (c) 2016, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 #include <fcntl.h>
 #include <launchpad/launchpad.h>
 #include <launchpad/vmo.h>
 #include <magenta/syscalls.h>
 #include <mxio/util.h>
 #include <pthread.h>
@@ skipping 13 matching lines @@
 
 // TODO(zra): Make this a command line argument
 const char* kRunVmTestsPath = "/boot/bin/dart_vm_tests";
 
 // Tests that are invalid, wedge, or cause panics.
 const char* kSkip[] = {
   // These expect a file to exist that we aren't putting in the image.
   "Read",
   "FileLength",
   "FilePosition",
-  // Crash and then Hang.
+  // Crash in abort() and then hang. (MG-252)
   "ArrayLengthMaxElements",
   "Int8ListLengthMaxElements",
+  "ArrayNew_Overflow_Crash",
+  "SNPrint_BadArgs",
+  "IsolateReload_PendingUnqualifiedCall_InstanceToStatic",
+  "IsolateReload_PendingUnqualifiedCall_StaticToInstance",
+  "IsolateReload_PendingConstructorCall_AbstractToConcrete",
+  "IsolateReload_PendingConstructorCall_ConcreteToAbstract",
+  "IsolateReload_PendingStaticCall_DefinedToNSM",
+  "IsolateReload_PendingStaticCall_NSMToDefined",
   // The profiler is turned off.
   "Profiler_AllocationSampleTest",
   "Profiler_ArrayAllocation",
   "Profiler_BasicSourcePosition",
   "Profiler_BasicSourcePositionOptimized",
   "Profiler_BinaryOperatorSourcePosition",
   "Profiler_BinaryOperatorSourcePositionOptimized",
   "Profiler_ChainedSamples",
   "Profiler_ClosureAllocation",
   "Profiler_CodeTicks",
@@ skipping 11 matching lines @@
   "Profiler_ToggleRecordAllocation",
   "Profiler_TrivialRecordAllocation",
   "Profiler_TypedArrayAllocation",
   "Profiler_GetSourceReport",
   "Service_Profile",
   // No realpath, files not in image.
   "Dart2JSCompilerStats",
   "Dart2JSCompileAll",
   // Uses too much memory.
   "PrintJSON",
-};
-
-// Expected to fail/crash.
-const char* kExpectFail[] = {
-  "Fail0",
-  "Fail1",
-  "Fail2",
-  "IsolateReload_PendingUnqualifiedCall_InstanceToStatic",
-  "IsolateReload_PendingUnqualifiedCall_StaticToInstance",
-  "IsolateReload_PendingConstructorCall_AbstractToConcrete",
-  "IsolateReload_PendingConstructorCall_ConcreteToAbstract",
-  "IsolateReload_PendingStaticCall_DefinedToNSM",
-  "IsolateReload_PendingStaticCall_NSMToDefined",
-  "ArrayNew_Overflow_Crash",
-  "AllocGeneric_Overflow",
-  "CodeImmutability",
-  "SNPrint_BadArgs",
-};
-
-// Bugs to fix, or things that are not yet impelemnted.
-const char* kBugs[] = {
-  // Needs OS::GetCurrentThreadCPUMicros.
+  // Need OS::GetCurrentThreadCPUMicros.
+  // Skipping because they crash and hang. (MG-252)
   "Timeline_Dart_TimelineGetTrace",
   "Timeline_Dart_TimelineGetTraceOnlyDartEvents",
   "Timeline_Dart_TimelineGetTraceWithDartEvents",
   "Timeline_Dart_TimelineGetTraceGlobalOverride",
   "Timeline_Dart_GlobalTimelineGetTrace",
   "Timeline_Dart_GlobalTimelineGetTrace_Threaded",
   "TimelineEventDuration",
   "TimelineEventDurationPrintJSON",
   "TimelineEventArguments",
   "TimelineEventArgumentsPrintJSON",
   "TimelineEventCallbackRecorderBasic",
   "TimelineAnalysis_ThreadBlockCount",
   "TimelineRingRecorderJSONOrder",
   "TimelinePauses_BeginEnd",
+};
+
+// Expected to fail/crash.
+const char* kExpectFail[] = {
+  "Fail0",
+  "Fail1",
+  "Fail2",
+  "AllocGeneric_Overflow",
+  "CodeImmutability",
+};
+
+// Bugs to fix, or things that are not yet impelemnted.

[siva, 2016/08/25 18:02:10]

implemented

[zra, 2016/08/25 18:14:14]

Done.

+const char* kBugs[] = {
   // Needs NativeSymbolResolver
   "Service_PersistentHandles",
-  // pthread TLS destructors are not run.
-  "ThreadIterator_AddFindRemove",
 };
 
 
 static bool contains(const char** list, intptr_t len, const char* str) {
   for (intptr_t i = 0; i < len; i++) {
     if (strcmp(list[i], str) == 0) {
       return true;
     }
   }
   return false;
@@ skipping 41 matching lines @@
   status = launchpad_arguments(lp, argc, argv);
   RETURN_IF_ERROR(status);
   status = launchpad_clone_mxio_root(lp);
   RETURN_IF_ERROR(status);
   status = launchpad_add_pipe(lp, stdout_out, 1);
   RETURN_IF_ERROR(status);
   status = launchpad_add_pipe(lp, stderr_out, 2);
   RETURN_IF_ERROR(status);
   status = launchpad_elf_load(lp, binary_vmo);
   RETURN_IF_ERROR(status);
+  status = launchpad_load_vdso(lp, MX_HANDLE_INVALID);
+  RETURN_IF_ERROR(status);
   *lp_out = lp;
   return status;
 }
 
 
 // Start the test running and return file descriptors for the stdout and stderr
 // pipes.
 static mx_handle_t start_test(mx_handle_t binary_vmo, const char* test_name,
                               int* stdout_out, int* stderr_out) {
   const intptr_t kArgc = 2;
@@ skipping 253 matching lines @@
   RETURN_IF_ERROR(status);
 
   // Complain if we didn't try to run all of the tests.
   if (test_list_index != lines_count) {
     fprintf(stderr, "Failed to attempt all the tests!\n");
     fflush(0);
     return -1;
   }
   return 0;
 }