Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(15)

Issue 2277283002: Reland of [turbofan] Insert dummy values when changing from None type. (Closed)

Created:
4 years, 3 months ago by Jarin
Modified:
4 years, 3 months ago
Reviewers:
Benedikt Meurer
CC:
v8-reviews_googlegroups.com, v8-mips-ports_googlegroups.com, v8-x87-ports_googlegroups.com, v8-ppc-ports_googlegroups.com, Michael Starzinger
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Reland of [turbofan] Insert dummy values when changing from None type. This reverts commit a55fdb1e7c19e2f9868190284df56bcf709dbf12, relands https://codereview.chromium.org/2266823002/. BUG=chromium:638132 Committed: https://crrev.com/2a97b1bcb16a905ae4c10ba11f8efdfe5e2b9946 Cr-Commit-Position: refs/heads/master@{#38917}

Patch Set 1 #

Patch Set 2 : Workaround for uninhabited representations. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+92 lines, -202 lines) Patch
M src/bailout-reason.h View 1 chunk +1 line, -3 lines 0 comments Download
M src/compiler/arm/code-generator-arm.cc View 1 chunk +0 lines, -3 lines 0 comments Download
M src/compiler/arm64/code-generator-arm64.cc View 1 chunk +0 lines, -3 lines 0 comments Download
M src/compiler/ia32/code-generator-ia32.cc View 1 chunk +0 lines, -3 lines 0 comments Download
M src/compiler/instruction-codes.h View 1 chunk +0 lines, -1 line 0 comments Download
M src/compiler/instruction-scheduler.cc View 1 chunk +0 lines, -1 line 0 comments Download
M src/compiler/instruction-selector.cc View 4 chunks +11 lines, -60 lines 0 comments Download
M src/compiler/machine-operator.h View 1 chunk +0 lines, -10 lines 0 comments Download
M src/compiler/machine-operator.cc View 1 chunk +0 lines, -6 lines 0 comments Download
M src/compiler/mips/code-generator-mips.cc View 1 chunk +0 lines, -3 lines 0 comments Download
M src/compiler/mips64/code-generator-mips64.cc View 1 chunk +0 lines, -3 lines 0 comments Download
M src/compiler/opcodes.h View 1 chunk +0 lines, -6 lines 0 comments Download
M src/compiler/ppc/code-generator-ppc.cc View 1 chunk +0 lines, -3 lines 0 comments Download
M src/compiler/representation-change.cc View 1 6 chunks +24 lines, -24 lines 0 comments Download
M src/compiler/s390/code-generator-s390.cc View 1 chunk +0 lines, -3 lines 0 comments Download
M src/compiler/simplified-lowering.cc View 4 chunks +11 lines, -5 lines 0 comments Download
M src/compiler/typer.cc View 1 chunk +0 lines, -22 lines 0 comments Download
M src/compiler/verifier.cc View 1 chunk +0 lines, -8 lines 0 comments Download
M src/compiler/x64/code-generator-x64.cc View 1 chunk +0 lines, -3 lines 0 comments Download
M src/compiler/x87/code-generator-x87.cc View 1 chunk +0 lines, -3 lines 0 comments Download
M test/cctest/compiler/test-representation-change.cc View 8 chunks +19 lines, -29 lines 0 comments Download
A test/mjsunit/compiler/regress-638132.js View 1 chunk +26 lines, -0 lines 0 comments Download

Messages

Total messages: 12 (7 generated)
Jarin
Could you take a look, please? I worked around the uninhabited type problem by using ...
4 years, 3 months ago (2016-08-25 14:03:54 UTC) #4
Benedikt Meurer
lgtm
4 years, 3 months ago (2016-08-25 16:54:56 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2277283002/20001
4 years, 3 months ago (2016-08-25 16:55:07 UTC) #9
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 3 months ago (2016-08-25 16:57:40 UTC) #10
commit-bot: I haz the power
4 years, 3 months ago (2016-08-25 16:58:24 UTC) #12
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/2a97b1bcb16a905ae4c10ba11f8efdfe5e2b9946
Cr-Commit-Position: refs/heads/master@{#38917}

Powered by Google App Engine
This is Rietveld 408576698