src/compiler/x87/code-generator-x87.cc - Issue 2277283002: Reland of [turbofan] Insert dummy values when changing from None type.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/compiler/x87/code-generator-x87.cc

Issue 2277283002: Reland of [turbofan] Insert dummy values when changing from None type. (Closed)

Patch Set: Workaround for uninhabited representations. Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: src/compiler/x87/code-generator-x87.cc

diff --git a/src/compiler/x87/code-generator-x87.cc b/src/compiler/x87/code-generator-x87.cc

index 1064e622eb8f05d39c0525462083fc6e13b89ed2..ae57bd019868e334890be360598111b9df7eabe0 100644

--- a/src/compiler/x87/code-generator-x87.cc

+++ b/src/compiler/x87/code-generator-x87.cc

@@ -715,9 +715,6 @@ CodeGenerator::CodeGenResult CodeGenerator::AssembleArchInstruction(

case kArchDebugBreak:

__ int3();

break;

- case kArchImpossible:

- __ Abort(kConversionFromImpossibleValue);

- break;

case kArchNop:

case kArchThrowTerminator:

// don't emit code for nops.