Use BytesConsumer in BodyStreamBuffer

Use BytesConsumer in BodyStreamBuffer

This CL makes BodyStreamBuffer use BytesConsumer instead of FetchDataConsumerHandle.
This CL also removed DataConsumerTee which is replaced by BytesConsumer::tee.

BUG=610195
Committed: https://crrev.com/21fc237b7c8bab86b12fd64453b4fa35a08cd621
Cr-Commit-Position: refs/heads/master@{#418284}

[yhirano, 2016-08-25 04:11:35]

The CQ bit was checked by yhirano@chromium.org to run a CQ dry run

[yhirano, 2016-08-25 04:29:31]

The CQ bit was checked by yhirano@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-08-25 04:30:02]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-25 04:37:41]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-25 04:37:42]

Dry run: Try jobs failed on following builders:
  linux_chromium_chromeos_ozone_rel_ng on master.tryserver.chromium.linux
(JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[yhirano, 2016-08-25 05:43:34]

The CQ bit was checked by yhirano@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-08-25 05:43:51]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-25 06:03:52]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-25 06:03:53]

Dry run: Try jobs failed on following builders:
  chromeos_daisy_chromium_compile_only_ng on master.tryserver.chromium.linux
(JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromeos_daisy_...)

[yhirano, 2016-08-25 08:59:37]

The CQ bit was checked by yhirano@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-08-25 08:59:58]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-25 09:10:25]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-25 09:10:26]

Dry run: Try jobs failed on following builders:
  mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

[yhirano, 2016-08-30 04:15:25]

The CQ bit was checked by yhirano@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-08-30 04:17:41]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[yhirano, 2016-08-30 04:18:32]

The CQ bit was checked by yhirano@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-08-30 04:26:15]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-30 05:56:59]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-30 05:57:00]

Dry run: This issue passed the CQ dry run.

[yhirano, 2016-08-30 06:02:09]

Patchset #3 (id:40001) has been deleted

[yhirano, 2016-08-30 06:02:14]

Patchset #2 (id:20001) has been deleted

[yhirano, 2016-08-30 06:02:19]

Patchset #1 (id:1) has been deleted

[yhirano, 2016-08-30 06:05:04]

Description was changed from

==========
[WIP] Make BodyStreamBuffer use BytesConsumer

wip

BUG=610195
==========

to

==========
Use BytesConsumer in BodyStreamBuffer

This CL makes BodyStreamBuffer use BytesConsumer instead of
FetchDataConsumerHandle.
This CL also removed DataConsumerTee which is replaced by BytesConsumer::tee.

BUG=610195
==========

[yhirano, 2016-08-30 06:05:05]

yhirano@chromium.org changed reviewers:
+ hiroshige@chromium.org

[yhirano, 2016-09-07 02:00:33]

The CQ bit was checked by yhirano@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-09-07 02:00:49]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-07 03:24:29]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-07 03:24:30]

Dry run: Try jobs failed on following builders:
  win_chromium_rel_ng on master.tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_...)

[yhirano, 2016-09-07 05:25:47]

The CQ bit was checked by yhirano@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-09-07 05:26:00]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-07 07:26:14]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-07 07:26:18]

Dry run: This issue passed the CQ dry run.

[hiroshige, 2016-09-07 09:25:54]

https://codereview.chromium.org/2277143002/diff/100001/third_party/WebKit/Sou...
File third_party/WebKit/Source/modules/fetch/BodyStreamBuffer.cpp (right):

https://codereview.chromium.org/2277143002/diff/100001/third_party/WebKit/Sou...
third_party/WebKit/Source/modules/fetch/BodyStreamBuffer.cpp:355:
m_consumer->endRead(available);
We have to check the return value of endRead().

https://codereview.chromium.org/2277143002/diff/100001/third_party/WebKit/Sou...
File third_party/WebKit/Source/modules/fetch/BodyStreamBufferTest.cpp (right):

https://codereview.chromium.org/2277143002/diff/100001/third_party/WebKit/Sou...
third_party/WebKit/Source/modules/fetch/BodyStreamBufferTest.cpp:83:
EXPECT_CALL(*client1, didFetchDataLoadedString(String("hello, world")));
What causes this behavior change?

[yhirano, 2016-09-08 01:40:28]

The CQ bit was checked by yhirano@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-09-08 01:40:48]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[yhirano, 2016-09-08 01:41:05]

https://codereview.chromium.org/2277143002/diff/100001/third_party/WebKit/Sou...
File third_party/WebKit/Source/modules/fetch/BodyStreamBuffer.cpp (right):

https://codereview.chromium.org/2277143002/diff/100001/third_party/WebKit/Sou...
third_party/WebKit/Source/modules/fetch/BodyStreamBuffer.cpp:355:
m_consumer->endRead(available);
On 2016/09/07 09:25:54, hiroshige wrote:
> We have to check the return value of endRead().

Done.

https://codereview.chromium.org/2277143002/diff/100001/third_party/WebKit/Sou...
File third_party/WebKit/Source/modules/fetch/BodyStreamBufferTest.cpp (right):

https://codereview.chromium.org/2277143002/diff/100001/third_party/WebKit/Sou...
third_party/WebKit/Source/modules/fetch/BodyStreamBufferTest.cpp:83:
EXPECT_CALL(*client1, didFetchDataLoadedString(String("hello, world")));
On 2016/09/07 09:25:54, hiroshige wrote:
> What causes this behavior change?

Unlike DataConsuerTee, BytesConsumerTee start enqueuing data synchronously. If
the loader starts reading synchronously as FetchDataLoader, the timing will
change.

[commit-bot: I haz the power, 2016-09-08 01:43:44]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-08 01:43:45]

Dry run: Try jobs failed on following builders:
  chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)
  mac_chromium_compile_dbg_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_comp...)

[yhirano, 2016-09-08 01:57:00]

The CQ bit was checked by yhirano@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-09-08 01:57:18]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-08 02:09:42]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-08 02:09:43]

Dry run: Try jobs failed on following builders:
  linux_chromium_chromeos_ozone_rel_ng on master.tryserver.chromium.linux
(JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[yhirano, 2016-09-08 02:13:33]

The CQ bit was checked by yhirano@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-09-08 02:13:57]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-08 03:30:46]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-08 03:30:47]

Dry run: Try jobs failed on following builders:
  win_chromium_compile_dbg_ng on master.tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_comp...)

[hiroshige, 2016-09-08 05:36:38]

lgtm

https://codereview.chromium.org/2277143002/diff/160001/third_party/WebKit/Sou...
File third_party/WebKit/Source/modules/fetch/BodyStreamBuffer.cpp (right):

https://codereview.chromium.org/2277143002/diff/160001/third_party/WebKit/Sou...
third_party/WebKit/Source/modules/fetch/BodyStreamBuffer.cpp:240: if
(m_consumer)
optional: splitting these three lines into a separate method might be better (as
this sequence is used here, close(), and error()).

[yhirano, 2016-09-08 05:50:01]

The CQ bit was checked by yhirano@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-09-08 05:50:18]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[yhirano, 2016-09-08 05:50:39]

https://codereview.chromium.org/2277143002/diff/160001/third_party/WebKit/Sou...
File third_party/WebKit/Source/modules/fetch/BodyStreamBuffer.cpp (right):

https://codereview.chromium.org/2277143002/diff/160001/third_party/WebKit/Sou...
third_party/WebKit/Source/modules/fetch/BodyStreamBuffer.cpp:240: if
(m_consumer)
On 2016/09/08 05:36:38, hiroshige wrote:
> optional: splitting these three lines into a separate method might be better
(as
> this sequence is used here, close(), and error()).

Done.

[commit-bot: I haz the power, 2016-09-08 08:18:05]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-08 08:18:06]

Dry run: This issue passed the CQ dry run.

[yhirano, 2016-09-12 08:13:52]

The CQ bit was checked by yhirano@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-09-12 08:14:07]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-12 10:11:36]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-12 10:11:37]

Dry run: This issue passed the CQ dry run.

[yhirano, 2016-09-13 07:52:37]

yhirano@chromium.org changed reviewers:
+ haraken@chromium.org

[yhirano, 2016-09-13 07:52:38]

+haraken@ for the modules/BUILD.gn change.

[haraken, 2016-09-13 07:59:34]

LGTM

[yhirano, 2016-09-13 15:57:52]

The CQ bit was checked by yhirano@chromium.org

[yhirano, 2016-09-13 15:57:53]

The patchset sent to the CQ was uploaded after l-g-t-m from
hiroshige@chromium.org
Link to the patchset: https://codereview.chromium.org/2277143002/#ps200001
(title: "rebase")

[commit-bot: I haz the power, 2016-09-13 15:58:13]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-13 17:28:16]

Description was changed from

==========
Use BytesConsumer in BodyStreamBuffer

This CL makes BodyStreamBuffer use BytesConsumer instead of
FetchDataConsumerHandle.
This CL also removed DataConsumerTee which is replaced by BytesConsumer::tee.

BUG=610195
==========

to

==========
Use BytesConsumer in BodyStreamBuffer

This CL makes BodyStreamBuffer use BytesConsumer instead of
FetchDataConsumerHandle.
This CL also removed DataConsumerTee which is replaced by BytesConsumer::tee.

BUG=610195
==========

[commit-bot: I haz the power, 2016-09-13 17:28:18]

Committed patchset #8 (id:200001)

[commit-bot: I haz the power, 2016-09-13 17:30:56]

Description was changed from

==========
Use BytesConsumer in BodyStreamBuffer

This CL makes BodyStreamBuffer use BytesConsumer instead of
FetchDataConsumerHandle.
This CL also removed DataConsumerTee which is replaced by BytesConsumer::tee.

BUG=610195
==========

to

==========
Use BytesConsumer in BodyStreamBuffer

This CL makes BodyStreamBuffer use BytesConsumer instead of
FetchDataConsumerHandle.
This CL also removed DataConsumerTee which is replaced by BytesConsumer::tee.

BUG=610195

Committed: https://crrev.com/21fc237b7c8bab86b12fd64453b4fa35a08cd621
Cr-Commit-Position: refs/heads/master@{#418284}
==========

[commit-bot: I haz the power, 2016-09-13 17:30:58]

Patchset 8 (id:??) landed as
https://crrev.com/21fc237b7c8bab86b12fd64453b4fa35a08cd621
Cr-Commit-Position: refs/heads/master@{#418284}