Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(340)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: third_party/WebKit/Source/modules/fetch/DataConsumerTeeTest.cpp

Issue 2277143002: Use BytesConsumer in BodyStreamBuffer (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@bytes-consumer-tee
Patch Set: rebase Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « third_party/WebKit/Source/modules/fetch/DataConsumerTee.cpp ('k') | third_party/WebKit/Source/modules/serviceworkers/RespondWithObserver.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: third_party/WebKit/Source/modules/fetch/DataConsumerTeeTest.cpp
diff --git a/third_party/WebKit/Source/modules/fetch/DataConsumerTeeTest.cpp b/third_party/WebKit/Source/modules/fetch/DataConsumerTeeTest.cpp
deleted file mode 100644
index f3eed47b7fdc8adf559de89c0f99931f57360e3b..0000000000000000000000000000000000000000
--- a/third_party/WebKit/Source/modules/fetch/DataConsumerTeeTest.cpp
+++ /dev/null
@@ -1,418 +0,0 @@
-// Copyright 2015 The Chromium Authors. All rights reserved.
-// Use of this source code is governed by a BSD-style license that can be
-// found in the LICENSE file.
-
-#include "modules/fetch/DataConsumerTee.h"
-
-#include "core/testing/DummyPageHolder.h"
-#include "core/testing/NullExecutionContext.h"
-#include "modules/fetch/DataConsumerHandleTestUtil.h"
-#include "platform/CrossThreadFunctional.h"
-#include "platform/WaitableEvent.h"
-#include "platform/WebThreadSupportingGC.h"
-#include "public/platform/Platform.h"
-#include "public/platform/WebThread.h"
-#include "public/platform/WebTraceLocation.h"
-#include "testing/gtest/include/gtest/gtest.h"
-#include "wtf/PassRefPtr.h"
-#include "wtf/PtrUtil.h"
-#include "wtf/RefPtr.h"
-#include <memory>
-#include <string.h>
-#include <v8.h>
-
-namespace blink {
-namespace {
-
-using ::testing::ByMove;
-using ::testing::InSequence;
-using ::testing::Return;
-using ::testing::StrictMock;
-using ::testing::_;
-using Checkpoint = StrictMock<::testing::MockFunction<void(int)>>;
-
-using Result = WebDataConsumerHandle::Result;
-using Thread = DataConsumerHandleTestUtil::Thread;
-const Result kDone = WebDataConsumerHandle::Done;
-const Result kUnexpectedError = WebDataConsumerHandle::UnexpectedError;
-const FetchDataConsumerHandle::Reader::BlobSizePolicy kDisallowBlobWithInvalidSize = FetchDataConsumerHandle::Reader::DisallowBlobWithInvalidSize;
-const FetchDataConsumerHandle::Reader::BlobSizePolicy kAllowBlobWithInvalidSize = FetchDataConsumerHandle::Reader::AllowBlobWithInvalidSize;
-
-using Command = DataConsumerHandleTestUtil::Command;
-using Handle = DataConsumerHandleTestUtil::ReplayingHandle;
-using HandleReader = DataConsumerHandleTestUtil::HandleReader;
-using HandleTwoPhaseReader = DataConsumerHandleTestUtil::HandleTwoPhaseReader;
-using HandleReadResult = DataConsumerHandleTestUtil::HandleReadResult;
-using MockFetchDataConsumerHandle = DataConsumerHandleTestUtil::MockFetchDataConsumerHandle;
-using MockFetchDataConsumerReader = DataConsumerHandleTestUtil::MockFetchDataConsumerReader;
-template <typename T>
-using HandleReaderRunner = DataConsumerHandleTestUtil::HandleReaderRunner<T>;
-
-String toString(const Vector<char>& v)
-{
- return String(v.data(), v.size());
-}
-
-template<typename Handle>
-class TeeCreationThread {
-public:
- void run(std::unique_ptr<Handle> src, std::unique_ptr<Handle>* dest1, std::unique_ptr<Handle>* dest2)
- {
- m_thread = wrapUnique(new Thread("src thread", Thread::WithExecutionContext));
- m_waitableEvent = wrapUnique(new WaitableEvent());
- m_thread->thread()->postTask(BLINK_FROM_HERE, crossThreadBind(&TeeCreationThread<Handle>::runInternal, crossThreadUnretained(this), passed(std::move(src)), crossThreadUnretained(dest1), crossThreadUnretained(dest2)));
- m_waitableEvent->wait();
- }
-
- Thread* getThread() { return m_thread.get(); }
-
-private:
- void runInternal(std::unique_ptr<Handle> src, std::unique_ptr<Handle>* dest1, std::unique_ptr<Handle>* dest2)
- {
- DataConsumerTee::create(m_thread->getExecutionContext(), std::move(src), dest1, dest2);
- m_waitableEvent->signal();
- }
-
- std::unique_ptr<Thread> m_thread;
- std::unique_ptr<WaitableEvent> m_waitableEvent;
-};
-
-TEST(DataConsumerTeeTest, CreateDone)
-{
- std::unique_ptr<Handle> src(Handle::create());
- std::unique_ptr<WebDataConsumerHandle> dest1, dest2;
-
- src->add(Command(Command::Done));
-
- std::unique_ptr<TeeCreationThread<WebDataConsumerHandle>> t = wrapUnique(new TeeCreationThread<WebDataConsumerHandle>());
- t->run(std::move(src), &dest1, &dest2);
-
- ASSERT_TRUE(dest1);
- ASSERT_TRUE(dest2);
-
- HandleReaderRunner<HandleReader> r1(std::move(dest1)), r2(std::move(dest2));
-
- std::unique_ptr<HandleReadResult> res1 = r1.wait();
- std::unique_ptr<HandleReadResult> res2 = r2.wait();
-
- EXPECT_EQ(kDone, res1->result());
- EXPECT_EQ(0u, res1->data().size());
- EXPECT_EQ(kDone, res2->result());
- EXPECT_EQ(0u, res2->data().size());
-}
-
-TEST(DataConsumerTeeTest, Read)
-{
- std::unique_ptr<Handle> src(Handle::create());
- std::unique_ptr<WebDataConsumerHandle> dest1, dest2;
-
- src->add(Command(Command::Wait));
- src->add(Command(Command::Data, "hello, "));
- src->add(Command(Command::Wait));
- src->add(Command(Command::Data, "world"));
- src->add(Command(Command::Wait));
- src->add(Command(Command::Wait));
- src->add(Command(Command::Done));
-
- std::unique_ptr<TeeCreationThread<WebDataConsumerHandle>> t = wrapUnique(new TeeCreationThread<WebDataConsumerHandle>());
- t->run(std::move(src), &dest1, &dest2);
-
- ASSERT_TRUE(dest1);
- ASSERT_TRUE(dest2);
-
- HandleReaderRunner<HandleReader> r1(std::move(dest1));
- HandleReaderRunner<HandleReader> r2(std::move(dest2));
-
- std::unique_ptr<HandleReadResult> res1 = r1.wait();
- std::unique_ptr<HandleReadResult> res2 = r2.wait();
-
- EXPECT_EQ(kDone, res1->result());
- EXPECT_EQ("hello, world", toString(res1->data()));
-
- EXPECT_EQ(kDone, res2->result());
- EXPECT_EQ("hello, world", toString(res2->data()));
-}
-
-TEST(DataConsumerTeeTest, TwoPhaseRead)
-{
- std::unique_ptr<Handle> src(Handle::create());
- std::unique_ptr<WebDataConsumerHandle> dest1, dest2;
-
- src->add(Command(Command::Wait));
- src->add(Command(Command::Data, "hello, "));
- src->add(Command(Command::Wait));
- src->add(Command(Command::Wait));
- src->add(Command(Command::Wait));
- src->add(Command(Command::Data, "world"));
- src->add(Command(Command::Wait));
- src->add(Command(Command::Done));
-
- std::unique_ptr<TeeCreationThread<WebDataConsumerHandle>> t = wrapUnique(new TeeCreationThread<WebDataConsumerHandle>());
- t->run(std::move(src), &dest1, &dest2);
-
- ASSERT_TRUE(dest1);
- ASSERT_TRUE(dest2);
-
- HandleReaderRunner<HandleTwoPhaseReader> r1(std::move(dest1));
- HandleReaderRunner<HandleTwoPhaseReader> r2(std::move(dest2));
-
- std::unique_ptr<HandleReadResult> res1 = r1.wait();
- std::unique_ptr<HandleReadResult> res2 = r2.wait();
-
- EXPECT_EQ(kDone, res1->result());
- EXPECT_EQ("hello, world", toString(res1->data()));
-
- EXPECT_EQ(kDone, res2->result());
- EXPECT_EQ("hello, world", toString(res2->data()));
-}
-
-TEST(DataConsumerTeeTest, Error)
-{
- std::unique_ptr<Handle> src(Handle::create());
- std::unique_ptr<WebDataConsumerHandle> dest1, dest2;
-
- src->add(Command(Command::Data, "hello, "));
- src->add(Command(Command::Data, "world"));
- src->add(Command(Command::Error));
-
- std::unique_ptr<TeeCreationThread<WebDataConsumerHandle>> t = wrapUnique(new TeeCreationThread<WebDataConsumerHandle>());
- t->run(std::move(src), &dest1, &dest2);
-
- ASSERT_TRUE(dest1);
- ASSERT_TRUE(dest2);
-
- HandleReaderRunner<HandleReader> r1(std::move(dest1));
- HandleReaderRunner<HandleReader> r2(std::move(dest2));
-
- std::unique_ptr<HandleReadResult> res1 = r1.wait();
- std::unique_ptr<HandleReadResult> res2 = r2.wait();
-
- EXPECT_EQ(kUnexpectedError, res1->result());
- EXPECT_EQ(kUnexpectedError, res2->result());
-}
-
-void postStop(Thread* thread)
-{
- thread->getExecutionContext()->stopActiveDOMObjects();
-}
-
-TEST(DataConsumerTeeTest, StopSource)
-{
- std::unique_ptr<Handle> src(Handle::create());
- std::unique_ptr<WebDataConsumerHandle> dest1, dest2;
-
- src->add(Command(Command::Data, "hello, "));
- src->add(Command(Command::Data, "world"));
-
- std::unique_ptr<TeeCreationThread<WebDataConsumerHandle>> t = wrapUnique(new TeeCreationThread<WebDataConsumerHandle>());
- t->run(std::move(src), &dest1, &dest2);
-
- ASSERT_TRUE(dest1);
- ASSERT_TRUE(dest2);
-
- HandleReaderRunner<HandleReader> r1(std::move(dest1));
- HandleReaderRunner<HandleReader> r2(std::move(dest2));
-
- // We can pass a raw pointer because the subsequent |wait| calls ensure
- // t->thread() is alive.
- t->getThread()->thread()->postTask(BLINK_FROM_HERE, crossThreadBind(postStop, crossThreadUnretained(t->getThread())));
-
- std::unique_ptr<HandleReadResult> res1 = r1.wait();
- std::unique_ptr<HandleReadResult> res2 = r2.wait();
-
- EXPECT_EQ(kUnexpectedError, res1->result());
- EXPECT_EQ(kUnexpectedError, res2->result());
-}
-
-TEST(DataConsumerTeeTest, DetachSource)
-{
- std::unique_ptr<Handle> src(Handle::create());
- std::unique_ptr<WebDataConsumerHandle> dest1, dest2;
-
- src->add(Command(Command::Data, "hello, "));
- src->add(Command(Command::Data, "world"));
-
- std::unique_ptr<TeeCreationThread<WebDataConsumerHandle>> t = wrapUnique(new TeeCreationThread<WebDataConsumerHandle>());
- t->run(std::move(src), &dest1, &dest2);
-
- ASSERT_TRUE(dest1);
- ASSERT_TRUE(dest2);
-
- HandleReaderRunner<HandleReader> r1(std::move(dest1));
- HandleReaderRunner<HandleReader> r2(std::move(dest2));
-
- t = nullptr;
-
- std::unique_ptr<HandleReadResult> res1 = r1.wait();
- std::unique_ptr<HandleReadResult> res2 = r2.wait();
-
- EXPECT_EQ(kUnexpectedError, res1->result());
- EXPECT_EQ(kUnexpectedError, res2->result());
-}
-
-TEST(DataConsumerTeeTest, DetachSourceAfterReadingDone)
-{
- std::unique_ptr<Handle> src(Handle::create());
- std::unique_ptr<WebDataConsumerHandle> dest1, dest2;
-
- src->add(Command(Command::Data, "hello, "));
- src->add(Command(Command::Data, "world"));
- src->add(Command(Command::Done));
-
- std::unique_ptr<TeeCreationThread<WebDataConsumerHandle>> t = wrapUnique(new TeeCreationThread<WebDataConsumerHandle>());
- t->run(std::move(src), &dest1, &dest2);
-
- ASSERT_TRUE(dest1);
- ASSERT_TRUE(dest2);
-
- HandleReaderRunner<HandleReader> r1(std::move(dest1));
- std::unique_ptr<HandleReadResult> res1 = r1.wait();
-
- EXPECT_EQ(kDone, res1->result());
- EXPECT_EQ("hello, world", toString(res1->data()));
-
- t = nullptr;
-
- HandleReaderRunner<HandleReader> r2(std::move(dest2));
- std::unique_ptr<HandleReadResult> res2 = r2.wait();
-
- EXPECT_EQ(kDone, res2->result());
- EXPECT_EQ("hello, world", toString(res2->data()));
-}
-
-TEST(DataConsumerTeeTest, DetachOneDestination)
-{
- std::unique_ptr<Handle> src(Handle::create());
- std::unique_ptr<WebDataConsumerHandle> dest1, dest2;
-
- src->add(Command(Command::Data, "hello, "));
- src->add(Command(Command::Data, "world"));
- src->add(Command(Command::Done));
-
- std::unique_ptr<TeeCreationThread<WebDataConsumerHandle>> t = wrapUnique(new TeeCreationThread<WebDataConsumerHandle>());
- t->run(std::move(src), &dest1, &dest2);
-
- ASSERT_TRUE(dest1);
- ASSERT_TRUE(dest2);
-
- dest1 = nullptr;
-
- HandleReaderRunner<HandleReader> r2(std::move(dest2));
- std::unique_ptr<HandleReadResult> res2 = r2.wait();
-
- EXPECT_EQ(kDone, res2->result());
- EXPECT_EQ("hello, world", toString(res2->data()));
-}
-
-TEST(DataConsumerTeeTest, DetachBothDestinationsShouldStopSourceReader)
-{
- std::unique_ptr<Handle> src(Handle::create());
- RefPtr<Handle::Context> context(src->getContext());
- std::unique_ptr<WebDataConsumerHandle> dest1, dest2;
-
- src->add(Command(Command::Data, "hello, "));
- src->add(Command(Command::Data, "world"));
-
- std::unique_ptr<TeeCreationThread<WebDataConsumerHandle>> t = wrapUnique(new TeeCreationThread<WebDataConsumerHandle>());
- t->run(std::move(src), &dest1, &dest2);
-
- ASSERT_TRUE(dest1);
- ASSERT_TRUE(dest2);
-
- dest1 = nullptr;
- dest2 = nullptr;
-
- // Collect garbage to finalize the source reader.
- ThreadState::current()-> collectAllGarbage();
- context->detached()->wait();
-}
-
-TEST(FetchDataConsumerTeeTest, Create)
-{
- RefPtr<BlobDataHandle> blobDataHandle = BlobDataHandle::create();
- std::unique_ptr<MockFetchDataConsumerHandle> src(MockFetchDataConsumerHandle::create());
-
- // |reader| will be adopted by |obtainFetchDataReader|.
- MockFetchDataConsumerReader* reader = MockFetchDataConsumerReader::create().release();
-
- Checkpoint checkpoint;
- InSequence s;
- EXPECT_CALL(checkpoint, Call(1));
- EXPECT_CALL(*src, obtainFetchDataReader(_)).WillOnce(Return(ByMove(WTF::wrapUnique(reader))));
- EXPECT_CALL(*reader, drainAsBlobDataHandle(kAllowBlobWithInvalidSize)).WillOnce(Return(blobDataHandle));
- EXPECT_CALL(*reader, destruct());
- EXPECT_CALL(checkpoint, Call(2));
-
- std::unique_ptr<FetchDataConsumerHandle> dest1, dest2;
- std::unique_ptr<TeeCreationThread<FetchDataConsumerHandle>> t = wrapUnique(new TeeCreationThread<FetchDataConsumerHandle>());
-
- checkpoint.Call(1);
- t->run(std::move(src), &dest1, &dest2);
- checkpoint.Call(2);
-
- ASSERT_TRUE(dest1);
- ASSERT_TRUE(dest2);
- EXPECT_EQ(blobDataHandle, dest1->obtainFetchDataReader(nullptr)->drainAsBlobDataHandle(kAllowBlobWithInvalidSize));
- EXPECT_EQ(blobDataHandle, dest2->obtainFetchDataReader(nullptr)->drainAsBlobDataHandle(kAllowBlobWithInvalidSize));
-}
-
-TEST(FetchDataConsumerTeeTest, CreateFromBlobWithInvalidSize)
-{
- RefPtr<BlobDataHandle> blobDataHandle = BlobDataHandle::create(BlobData::create(), -1);
- std::unique_ptr<MockFetchDataConsumerHandle> src(MockFetchDataConsumerHandle::create());
-
- // |reader| is adopted by |obtainFetchDataReader|.
- MockFetchDataConsumerReader* reader = MockFetchDataConsumerReader::create().release();
-
- Checkpoint checkpoint;
- InSequence s;
- EXPECT_CALL(checkpoint, Call(1));
- EXPECT_CALL(*src, obtainFetchDataReader(_)).WillOnce(Return(ByMove(WTF::wrapUnique(reader))));
- EXPECT_CALL(*reader, drainAsBlobDataHandle(kAllowBlobWithInvalidSize)).WillOnce(Return(blobDataHandle));
- EXPECT_CALL(*reader, destruct());
- EXPECT_CALL(checkpoint, Call(2));
-
- std::unique_ptr<FetchDataConsumerHandle> dest1, dest2;
- std::unique_ptr<TeeCreationThread<FetchDataConsumerHandle>> t = wrapUnique(new TeeCreationThread<FetchDataConsumerHandle>());
-
- checkpoint.Call(1);
- t->run(std::move(src), &dest1, &dest2);
- checkpoint.Call(2);
-
- ASSERT_TRUE(dest1);
- ASSERT_TRUE(dest2);
- EXPECT_FALSE(dest1->obtainFetchDataReader(nullptr)->drainAsBlobDataHandle(kDisallowBlobWithInvalidSize));
- EXPECT_EQ(blobDataHandle, dest1->obtainFetchDataReader(nullptr)->drainAsBlobDataHandle(kAllowBlobWithInvalidSize));
- EXPECT_FALSE(dest2->obtainFetchDataReader(nullptr)->drainAsBlobDataHandle(kDisallowBlobWithInvalidSize));
- EXPECT_EQ(blobDataHandle, dest2->obtainFetchDataReader(nullptr)->drainAsBlobDataHandle(kAllowBlobWithInvalidSize));
-}
-
-TEST(FetchDataConsumerTeeTest, CreateDone)
-{
- std::unique_ptr<Handle> src(Handle::create());
- std::unique_ptr<FetchDataConsumerHandle> dest1, dest2;
-
- src->add(Command(Command::Done));
-
- std::unique_ptr<TeeCreationThread<FetchDataConsumerHandle>> t = wrapUnique(new TeeCreationThread<FetchDataConsumerHandle>());
- t->run(createFetchDataConsumerHandleFromWebHandle(std::move(src)), &dest1, &dest2);
-
- ASSERT_TRUE(dest1);
- ASSERT_TRUE(dest2);
-
- EXPECT_FALSE(dest1->obtainFetchDataReader(nullptr)->drainAsBlobDataHandle(kAllowBlobWithInvalidSize));
- EXPECT_FALSE(dest2->obtainFetchDataReader(nullptr)->drainAsBlobDataHandle(kAllowBlobWithInvalidSize));
-
- HandleReaderRunner<HandleReader> r1(std::move(dest1)), r2(std::move(dest2));
-
- std::unique_ptr<HandleReadResult> res1 = r1.wait();
- std::unique_ptr<HandleReadResult> res2 = r2.wait();
-
- EXPECT_EQ(kDone, res1->result());
- EXPECT_EQ(0u, res1->data().size());
- EXPECT_EQ(kDone, res2->result());
- EXPECT_EQ(0u, res2->data().size());
-}
-
-} // namespace
-} // namespace blink
« no previous file with comments | « third_party/WebKit/Source/modules/fetch/DataConsumerTee.cpp ('k') | third_party/WebKit/Source/modules/serviceworkers/RespondWithObserver.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698