[USS] Move GetAllNodes from backend to controller

components/browser_sync/browser/profile_sync_service.h

Index: components/browser_sync/browser/profile_sync_service.h
diff --git a/components/browser_sync/browser/profile_sync_service.h b/components/browser_sync/browser/profile_sync_service.h
index f6c426846c7385446f3a789785bec1c64988ead9..9ccd5245210b9a9a3ffe711f232c1e1846a87038 100644
--- a/components/browser_sync/browser/profile_sync_service.h
+++ b/components/browser_sync/browser/profile_sync_service.h
@@ -332,6 +332,18 @@ class ProfileSyncService : public sync_driver::SyncService,
   base::WeakPtr<syncer::JsController> GetJsController() override;
   void GetAllNodes(const base::Callback<void(std::unique_ptr<base::ListValue>)>&
                        callback) override;
+  // Returns a ListValue representing all nodes for the specified types through
+  // |callback| on this thread.
+  void AllNodesForTypes(
+      syncer::ModelTypeSet types,
+      base::Callback<void(const syncer::ModelType,
+                          ScopedVector<base::ListValue>)> type);
+
+  void GetAllNodesForTypes(

[pavely, 2016/08/26 23:17:09]

I think you only have/use GetAllNodesForTypes in implementation.

[Gang Wu, 2016/08/29 20:07:41]

Done.

+      syncer::ModelTypeSet types,
+      base::Callback<void(const syncer::ModelType type,
+                          std::unique_ptr<base::ListValue>)> callback);
+  std::unique_ptr<base::ListValue> GetAllNodesForType(syncer::ModelType type);
 
   // Add a sync type preference provider. Each provider may only be added once.
   void AddPreferenceProvider(SyncTypePreferenceProvider* provider);
@@ -939,6 +951,7 @@ class ProfileSyncService : public sync_driver::SyncService,
   //     * If sync is disabled, PSS claims ownership from backend.
   //     * If sync is reenabled, PSS passes ownership to new backend.
   std::unique_ptr<base::Thread> sync_thread_;
+  base::Thread* sync_thread_test_;

[pavely, 2016/08/26 23:17:09]

Cleanup.

[Gang Wu, 2016/08/29 20:07:41]

I dont know where this line come from, will delete in next iteration

[Gang Wu, 2016/08/29 20:07:41]

Done.

 
   // ProfileSyncService uses this service to get access tokens.
   ProfileOAuth2TokenService* const oauth2_token_service_;