[USS] Move GetAllNodes from backend to controller

components/browser_sync/browser/profile_sync_service.h

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef COMPONENTS_BROWSER_SYNC_BROWSER_PROFILE_SYNC_SERVICE_H_
 #define COMPONENTS_BROWSER_SYNC_BROWSER_PROFILE_SYNC_SERVICE_H_
 
 #include <memory>
 #include <set>
 #include <string>
@@ skipping 314 matching lines @@
       browser_sync::ProtocolEventObserver* observer) override;
   void RemoveProtocolEventObserver(
       browser_sync::ProtocolEventObserver* observer) override;
   void AddTypeDebugInfoObserver(
       syncer::TypeDebugInfoObserver* observer) override;
   void RemoveTypeDebugInfoObserver(
       syncer::TypeDebugInfoObserver* observer) override;
   base::WeakPtr<syncer::JsController> GetJsController() override;
   void GetAllNodes(const base::Callback<void(std::unique_ptr<base::ListValue>)>&
                        callback) override;
+  // Returns a ListValue representing all nodes for the specified types through
+  // |callback| on this thread.
+  void AllNodesForTypes(
+      syncer::ModelTypeSet types,
+      base::Callback<void(const syncer::ModelType,
+                          ScopedVector<base::ListValue>)> type);
+
+  void GetAllNodesForTypes(

[pavely, 2016/08/26 23:17:09]

I think you only have/use GetAllNodesForTypes in implementation.

[Gang Wu, 2016/08/29 20:07:41]

Done.

+      syncer::ModelTypeSet types,
+      base::Callback<void(const syncer::ModelType type,
+                          std::unique_ptr<base::ListValue>)> callback);
+  std::unique_ptr<base::ListValue> GetAllNodesForType(syncer::ModelType type);
 
   // Add a sync type preference provider. Each provider may only be added once.
   void AddPreferenceProvider(SyncTypePreferenceProvider* provider);
   // Remove a sync type preference provider. May only be called for providers
   // that have been added. Providers must not remove themselves while being
   // called back.
   void RemovePreferenceProvider(SyncTypePreferenceProvider* provider);
   // Check whether a given sync type preference provider has been added.
   bool HasPreferenceProvider(SyncTypePreferenceProvider* provider) const;
 
@@ skipping 587 matching lines @@
   // Sync's internal debug info listener. Used to record datatype configuration
   // and association information.
   syncer::WeakHandle<syncer::DataTypeDebugInfoListener> debug_info_listener_;
 
   // A thread where all the sync operations happen.
   // OWNERSHIP Notes:
   //     * Created when backend starts for the first time.
   //     * If sync is disabled, PSS claims ownership from backend.
   //     * If sync is reenabled, PSS passes ownership to new backend.
   std::unique_ptr<base::Thread> sync_thread_;
+  base::Thread* sync_thread_test_;

[pavely, 2016/08/26 23:17:09]

Cleanup.

[Gang Wu, 2016/08/29 20:07:41]

I dont know where this line come from, will delete in next iteration

[Gang Wu, 2016/08/29 20:07:41]

Done.

 
   // ProfileSyncService uses this service to get access tokens.
   ProfileOAuth2TokenService* const oauth2_token_service_;
 
   // ProfileSyncService needs to remember access token in order to invalidate it
   // with OAuth2TokenService.
   std::string access_token_;
 
   // ProfileSyncService needs to hold reference to access_token_request_ for
   // the duration of request in order to receive callbacks.
@@ skipping 68 matching lines @@
   base::WeakPtrFactory<ProfileSyncService> weak_factory_;
 
   DISALLOW_COPY_AND_ASSIGN(ProfileSyncService);
 };
 
 bool ShouldShowActionOnUI(
     const syncer::SyncProtocolError& error);
 
 
 #endif  // COMPONENTS_BROWSER_SYNC_BROWSER_PROFILE_SYNC_SERVICE_H_