[system-health] Add support for recording stories directly through story set

[system-health] Add support for recording stories directly through story set

Until now, System Health stories had to be recorded through a benchmark,
e.g. system_health.memory_*:

  tools/perf/record_wpr mobile_memory_system_health
  tools/perf/record_wpr desktop_memory_system_health

This goes against the idea of SH stories being reusable across multiple
benchmarks. Instead, it is now possible (and recommended) to record
directly through the story set:

  tools/perf/record_wpr mobile_system_health_story_set
  tools/perf/record_wpr desktop_system_health_story_set

This will ensure that all SH stories are recorded under the same
conditions (10s wait at the end of the story without a memory dump).

BUG=589726
Committed: https://crrev.com/bac49d5c438537da3a6230aa50e00df5e725d608
Cr-Commit-Position: refs/heads/master@{#414373}

[petrcermak, 2016-08-24 15:55:27]

petrcermak@chromium.org changed reviewers:
+ nednguyen@google.com

[petrcermak, 2016-08-24 15:55:28]

PTAL.

Thanks,
Petr

[nednguyen, 2016-08-24 17:21:59]

lgtm

Can you update the System health FAQ doc to include the instruction for
recording?

[nednguyen, 2016-08-24 17:23:39]

https://codereview.chromium.org/2276943002/diff/1/tools/perf/page_sets/system...
File tools/perf/page_sets/system_health/system_health_stories.py (right):

https://codereview.chromium.org/2276943002/diff/1/tools/perf/page_sets/system...
tools/perf/page_sets/system_health/system_health_stories.py:43:
super(DesktopSystemHealthStorySet, self).__init__('desktop')
nits: explicitly specify take_memory_measurement=False to make it more resilient
in case we change the default param.

[petrcermak, 2016-08-24 17:49:46]

Thanks for your comments. I updated the FAQ as you suggested.

Petr

https://codereview.chromium.org/2276943002/diff/1/tools/perf/page_sets/system...
File tools/perf/page_sets/system_health/system_health_stories.py (right):

https://codereview.chromium.org/2276943002/diff/1/tools/perf/page_sets/system...
tools/perf/page_sets/system_health/system_health_stories.py:43:
super(DesktopSystemHealthStorySet, self).__init__('desktop')
On 2016/08/24 17:23:39, nednguyen wrote:
> nits: explicitly specify take_memory_measurement=False to make it more
resilient
> in case we change the default param.

Done.

[petrcermak, 2016-08-24 17:50:00]

The CQ bit was checked by petrcermak@chromium.org

[petrcermak, 2016-08-24 17:50:00]

The patchset sent to the CQ was uploaded after l-g-t-m from nednguyen@google.com
Link to the patchset: https://codereview.chromium.org/2276943002/#ps20001
(title: "Explicit take_memory_measurement=False")

[commit-bot: I haz the power, 2016-08-24 17:51:15]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-24 19:54:18]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-24 19:54:19]

Try jobs failed on following builders:
  chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)

[petrcermak, 2016-08-25 09:20:59]

The CQ bit was checked by petrcermak@chromium.org

[commit-bot: I haz the power, 2016-08-25 09:21:22]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-25 09:28:21]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-08-25 09:29:29]

Description was changed from

==========
[system-health] Add support for recording stories directly through story set

Until now, System Health stories had to be recorded through a benchmark,
e.g. system_health.memory_*:

  tools/perf/record_wpr mobile_memory_system_health
  tools/perf/record_wpr desktop_memory_system_health

This goes against the idea of SH stories being reusable across multiple
benchmarks. Instead, it is now possible (and recommended) to record
directly through the story set:

  tools/perf/record_wpr mobile_system_health_story_set
  tools/perf/record_wpr desktop_system_health_story_set

This will ensure that all SH stories are recorded under the same
conditions (10s wait at the end of the story without a memory dump).

BUG=589726
==========

to

==========
[system-health] Add support for recording stories directly through story set

Until now, System Health stories had to be recorded through a benchmark,
e.g. system_health.memory_*:

  tools/perf/record_wpr mobile_memory_system_health
  tools/perf/record_wpr desktop_memory_system_health

This goes against the idea of SH stories being reusable across multiple
benchmarks. Instead, it is now possible (and recommended) to record
directly through the story set:

  tools/perf/record_wpr mobile_system_health_story_set
  tools/perf/record_wpr desktop_system_health_story_set

This will ensure that all SH stories are recorded under the same
conditions (10s wait at the end of the story without a memory dump).

BUG=589726

Committed: https://crrev.com/bac49d5c438537da3a6230aa50e00df5e725d608
Cr-Commit-Position: refs/heads/master@{#414373}
==========

[commit-bot: I haz the power, 2016-08-25 09:29:30]

Patchset 2 (id:??) landed as
https://crrev.com/bac49d5c438537da3a6230aa50e00df5e725d608
Cr-Commit-Position: refs/heads/master@{#414373}