Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(16)

Unified Diff: tools/perf/page_sets/system_health/system_health_story.py

Issue 2276943002: [system-health] Add support for recording stories directly through story set (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Explicit take_memory_measurement=False Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « tools/perf/page_sets/system_health/system_health_stories.py ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tools/perf/page_sets/system_health/system_health_story.py
diff --git a/tools/perf/page_sets/system_health/system_health_story.py b/tools/perf/page_sets/system_health/system_health_story.py
index 4b73c94ccbba1ae03244f89270ee5fa4851bacdc..394710d3c32945e299f8d5528c94f77fa04be051 100644
--- a/tools/perf/page_sets/system_health/system_health_story.py
+++ b/tools/perf/page_sets/system_health/system_health_story.py
@@ -47,25 +47,11 @@ class SystemHealthStory(page.Page):
self._take_memory_measurement = take_memory_measurement
def _Measure(self, action_runner):
- if self._ShouldMeasureMemory(action_runner):
+ if self._take_memory_measurement:
action_runner.MeasureMemory(deterministic_mode=True)
else:
action_runner.Wait(_WAIT_TIME_AFTER_LOAD)
- def _ShouldMeasureMemory(self, action_runner):
- if not self._take_memory_measurement:
- return False
- # The check below is also performed in action_runner.MeasureMemory().
- # However, we need to duplicate it here so that the story would wait for
- # |_WAIT_TIME_AFTER_LOAD| seconds after load when recorded via the
- # system_health.memory_* benchmarks.
- # TODO(petrcermak): Make it possible (and mandatory) to record the story
- # directly through the story set and remove this check.
- tracing_controller = action_runner.tab.browser.platform.tracing_controller
- if not tracing_controller.is_tracing_running:
- return False # Tracing is not running, e.g. when recording a WPR archive.
- return True
-
def _Login(self, action_runner):
pass
« no previous file with comments | « tools/perf/page_sets/system_health/system_health_stories.py ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698