Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(268)

Issue 2276743004: DevTools: Use stableSort for async events (Closed)

Created:
4 years, 4 months ago by alph
Modified:
4 years, 3 months ago
Reviewers:
paulirish, caseq
CC:
apavlov+blink_chromium.org, blink-reviews, caseq+blink_chromium.org, chromium-reviews, devtools-reviews_chromium.org, kozyatinskiy+blink_chromium.org, lushnikov+blink_chromium.org, pfeldman+blink_chromium.org, pfeldman
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

DevTools: Use stableSort for async events Async events may have identicatl start and end time. Also make sure async events go the the right strip, not to input one. BUG=640652 Committed: https://crrev.com/7465824d77013dd37242713c7a2520be2b718345 Cr-Commit-Position: refs/heads/master@{#414506}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -5 lines) Patch
M third_party/WebKit/Source/devtools/front_end/sdk/TracingModel.js View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/devtools/front_end/timeline/TimelineFlameChart.js View 1 chunk +4 lines, -4 lines 0 comments Download

Messages

Total messages: 14 (7 generated)
alph
Kudos to Paul for helping track it down.
4 years, 4 months ago (2016-08-24 22:50:12 UTC) #2
paulirish
lgtm
4 years, 3 months ago (2016-08-25 19:21:35 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2276743004/1
4 years, 3 months ago (2016-08-25 19:22:29 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 3 months ago (2016-08-25 19:27:42 UTC) #10
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/7465824d77013dd37242713c7a2520be2b718345 Cr-Commit-Position: refs/heads/master@{#414506}
4 years, 3 months ago (2016-08-25 19:29:31 UTC) #12
caseq
a test?
4 years, 3 months ago (2016-08-25 19:31:00 UTC) #13
caseq
4 years, 3 months ago (2016-08-25 19:32:45 UTC) #14
Message was sent while issue was closed.
Also, should we remove extra async event sort from thread's tracing complete?

Powered by Google App Engine
This is Rietveld 408576698