third_party/WebKit/Source/devtools/front_end/timeline/TimelineFlameChart.js - Issue 2276743004: DevTools: Use stableSort for async events

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/devtools/front_end/timeline/TimelineFlameChart.js

Issue 2276743004: DevTools: Use stableSort for async events (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: third_party/WebKit/Source/devtools/front_end/timeline/TimelineFlameChart.js

diff --git a/third_party/WebKit/Source/devtools/front_end/timeline/TimelineFlameChart.js b/third_party/WebKit/Source/devtools/front_end/timeline/TimelineFlameChart.js

index 6d828a1deac55d510b6d732487f99fad8bd74f58..0f098e5f28efcf14486f87a22829b9c27725cded 100644

--- a/third_party/WebKit/Source/devtools/front_end/timeline/TimelineFlameChart.js

+++ b/third_party/WebKit/Source/devtools/front_end/timeline/TimelineFlameChart.js

@@ -562,10 +562,10 @@ WebInspector.TimelineFlameChartDataProvider.prototype = {

for (var groupIndex = 0; groupIndex < groupArray.length; ++groupIndex) {

var group = groupArray[groupIndex];

var events = asyncEvents.get(group);

- if (events) {

- var title = WebInspector.TimelineUIUtils.titleForAsyncEventGroup(groups.input);

- this._appendAsyncEventsGroup(title, events, this._headerLevel1);

- }

+ if (!events)

+ continue;

+ var title = WebInspector.TimelineUIUtils.titleForAsyncEventGroup(group);

+ this._appendAsyncEventsGroup(title, events, this._headerLevel1);

}

« no previous file with comments | « third_party/WebKit/Source/devtools/front_end/sdk/TracingModel.js ('k') | no next file » | no next file with comments »