More SkRecord TODOs:

More SkRecord TODOs:

  - add basic test for SkRecorder
  - rejigger GYPs so that the include dir comes along with the dependency

BUG=skia:2378
Committed: http://code.google.com/p/skia/source/detail?r=14099

NOTRY=true
NOTREECHECKS=true

Committed: http://code.google.com/p/skia/source/detail?r=14100

[f(malita), 2014-04-08 19:48:34]

lgtm

https://codereview.chromium.org/227673011/diff/1/tests/RecorderTest.cpp
File tests/RecorderTest.cpp (right):

https://codereview.chromium.org/227673011/diff/1/tests/RecorderTest.cpp#newcode8
tests/RecorderTest.cpp:8: static const int kRecordTypes = 0 +
SK_RECORD_TYPES(COUNT);
I guess it evals correctly, but I think we could drop "0 + " from this.

[mtklein, 2014-04-08 19:51:39]

lgtm

https://codereview.chromium.org/227673011/diff/1/tests/RecorderTest.cpp
File tests/RecorderTest.cpp (right):

https://codereview.chromium.org/227673011/diff/1/tests/RecorderTest.cpp#newcode8
tests/RecorderTest.cpp:8: static const int kRecordTypes = 0 +
SK_RECORD_TYPES(COUNT);
On 2014/04/08 19:48:34, Florin Malita wrote:
> I guess it evals correctly, but I think we could drop "0 + " from this.

Oooh, good call.  This was left over from before I realized I could trust unary
plus to make things easy.  I originally wrote "0 SK_RECORD_TYPES(COUNT)", but
that seemed confusing.  Done.

[mtklein, 2014-04-08 19:51:43]

The CQ bit was checked by mtklein@google.com

[commit-bot: I haz the power, 2014-04-08 19:51:46]

CQ is trying da patch. Follow status at
https://skia-tree-status.appspot.com/cq/mtklein@chromium.org/227673011/20001

[commit-bot: I haz the power, 2014-04-08 20:17:29]

Change committed as 14099

[mtklein, 2014-04-08 20:58:44]

The CQ bit was checked by mtklein@google.com

[commit-bot: I haz the power, 2014-04-08 20:58:45]

CQ is trying da patch. Follow status at
https://skia-tree-status.appspot.com/cq/mtklein@chromium.org/227673011/40001

[mtklein, 2014-04-08 20:58:56]

The CQ bit was unchecked by mtklein@google.com

[mtklein, 2014-04-08 20:58:56]

The CQ bit was checked by mtklein@google.com

[commit-bot: I haz the power, 2014-04-08 21:01:29]

Change committed as 14100