More SkRecord TODOs:

tests/RecorderTest.cpp

+#include "Test.h"
+
+#include "SkRecord.h"
+#include "SkRecorder.h"
+#include "SkRecords.h"
+
+#define COUNT(T) + 1
+static const int kRecordTypes = 0 + SK_RECORD_TYPES(COUNT);

[f(malita), 2014/04/08 19:48:34]

I guess it evals correctly, but I think we could drop "0 + " from this.

[mtklein, 2014/04/08 19:51:40]

Oooh, good call.  This was left over from before I realized I could trust unary
plus to make things easy.  I originally wrote "0 SK_RECORD_TYPES(COUNT)", but
that seemed confusing.  Done.

+#undef COUNT
+
+// Tallies the types of commands it sees into histogram.
+class Tally {
+public:
+    explicit Tally(int histogram[kRecordTypes]) : fHistogram(histogram) {}
+
+    template <typename T> void operator()(const T&) {
+        ++fHistogram[T::kType];
+    }
+
+private:
+    int* fHistogram;
+};
+
+DEF_TEST(Recorder, r) {
+    SkRecord record;
+    SkRecorder recorder(&record, 1920, 1080);
+
+    recorder.drawRect(SkRect::MakeWH(10, 10), SkPaint());
+
+    int histogram[kRecordTypes];
+    bzero(&histogram, sizeof(histogram));
+
+    record.visit(Tally(histogram));
+
+    REPORTER_ASSERT(r, 1 == histogram[SkRecords::DrawRect::kType]);
+}