Fix browser_tests run isolated on OSX.

Fix browser_tests run isolated on OSX.

osmesa.so is now a required dependency for this test to pass.

R=danakj@chromium.org
BUG=361362
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=262815

[M-A Ruel, 2014-04-08 12:43:45]

Not sure who started to force osmesa to be present on OSX but adding a few
random people who show up on the blame list.

[danakj, 2014-04-08 14:24:43]

Browser tests never use OSMesa right now, due to this line:
https://code.google.com/p/chromium/codesearch#chromium/src/content/public/tes...

So, I'm confused why this is needed. Is there a bisect or some context?

[M-A Ruel, 2014-04-08 14:34:08]

On 2014/04/08 14:24:43, danakj wrote:
> Browser tests never use OSMesa right now, due to this line:
>
https://code.google.com/p/chromium/codesearch#chromium/src/content/public/tes...
> 
> So, I'm confused why this is needed. Is there a bisect or some context?

http://build.chromium.org/p/chromium.swarm/builders/Mac%20Swarm%20Tests

It's consistently failing if this file is not mapped in. It's been so for a long
time.

You can reproduce with
ninja -C out/Release browser_tests_run
# Should succeed:
out/Release/browser_tests --gtest_filter=FormAutofillTest.Labels
# Will fail.
tools/swarming_client/isolate.py run -s out/Release/browser_tests.isolated --
--gtest_filter=FormAutofillTest.Labels
# Patch in this CL.
git cl patch 227673004
# Will succeed.
tools/swarming_client/isolate.py run -s out/Release/browser_tests.isolated --
--gtest_filter=FormAutofillTest.Labels

[danakj, 2014-04-08 23:03:00]

This is really odd, it appears that we have started initializing GL
bindings in the test/browser process. This isn't correct or intentional
AFAIK. This is probably from https://codereview.chromium.org/190663012


On Tue, Apr 8, 2014 at 10:34 AM, <maruel@chromium.org> wrote:

> On 2014/04/08 14:24:43, danakj wrote:
>
>> Browser tests never use OSMesa right now, due to this line:
>>
>
> https://code.google.com/p/chromium/codesearch#chromium/
> src/content/public/test/browser_test_base.cc&l=199
>
>  So, I'm confused why this is needed. Is there a bisect or some context?
>>
>
> http://build.chromium.org/p/chromium.swarm/builders/Mac%20Swarm%20Tests
>
> It's consistently failing if this file is not mapped in. It's been so for
> a long
> time.
>
> You can reproduce with
> ninja -C out/Release browser_tests_run
> # Should succeed:
> out/Release/browser_tests --gtest_filter=FormAutofillTest.Labels
> # Will fail.
> tools/swarming_client/isolate.py run -s out/Release/browser_tests.isolated
> --
> --gtest_filter=FormAutofillTest.Labels
> # Patch in this CL.
> git cl patch 227673004
> # Will succeed.
> tools/swarming_client/isolate.py run -s out/Release/browser_tests.isolated
> --
> --gtest_filter=FormAutofillTest.Labels
>
>
> https://codereview.chromium.org/227673004/
>

To unsubscribe from this group and stop receiving emails from it, send an email
to chromium-reviews+unsubscribe@chromium.org.

[danakj, 2014-04-08 23:05:38]

Filed https://code.google.com/p/chromium/issues/detail?id=361362


On Tue, Apr 8, 2014 at 7:02 PM, Dana Jansens <danakj@chromium.org> wrote:

> This is really odd, it appears that we have started initializing GL
> bindings in the test/browser process. This isn't correct or intentional
> AFAIK. This is probably from https://codereview.chromium.org/190663012
>
>
> On Tue, Apr 8, 2014 at 10:34 AM, <maruel@chromium.org> wrote:
>
>> On 2014/04/08 14:24:43, danakj wrote:
>>
>>> Browser tests never use OSMesa right now, due to this line:
>>>
>>
>> https://code.google.com/p/chromium/codesearch#chromium/
>> src/content/public/test/browser_test_base.cc&l=199
>>
>>  So, I'm confused why this is needed. Is there a bisect or some context?
>>>
>>
>> http://build.chromium.org/p/chromium.swarm/builders/Mac%20Swarm%20Tests
>>
>> It's consistently failing if this file is not mapped in. It's been so for
>> a long
>> time.
>>
>> You can reproduce with
>> ninja -C out/Release browser_tests_run
>> # Should succeed:
>> out/Release/browser_tests --gtest_filter=FormAutofillTest.Labels
>> # Will fail.
>> tools/swarming_client/isolate.py run -s out/Release/browser_tests.isolated
>> --
>> --gtest_filter=FormAutofillTest.Labels
>> # Patch in this CL.
>> git cl patch 227673004
>> # Will succeed.
>> tools/swarming_client/isolate.py run -s out/Release/browser_tests.isolated
>> --
>> --gtest_filter=FormAutofillTest.Labels
>>
>>
>> https://codereview.chromium.org/227673004/
>>
>
>

To unsubscribe from this group and stop receiving emails from it, send an email
to chromium-reviews+unsubscribe@chromium.org.

[danakj, 2014-04-09 17:31:30]

LGTM to make swarming work, as we have a bug to track this weird behaviour of
the browser_test suite.

[M-A Ruel, 2014-04-09 17:39:04]

The CQ bit was checked by maruel@chromium.org

[commit-bot: I haz the power, 2014-04-09 17:39:32]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/maruel@chromium.org/227673004/1

[commit-bot: I haz the power, 2014-04-09 21:13:10]

Change committed as 262815