Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(15)

Issue 227673003: enable developers to provide their own android toolchain (Closed)

Created:
6 years, 8 months ago by djsollen
Modified:
6 years, 8 months ago
Reviewers:
hal.canary, scroggo
CC:
skia-review_googlegroups.com
Visibility:
Public.

Description

enable developers to provide their own android toolchain Committed: http://code.google.com/p/skia/source/detail?r=14113

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+98 lines, -67 lines) Patch
M platform_tools/android/bin/android_setup.sh View 2 chunks +2 lines, -67 lines 2 comments Download
A platform_tools/android/bin/utils/setup_toolchain.sh View 1 chunk +96 lines, -0 lines 0 comments Download

Messages

Total messages: 8 (0 generated)
djsollen
6 years, 8 months ago (2014-04-07 14:42:18 UTC) #1
djsollen
6 years, 8 months ago (2014-04-09 14:11:52 UTC) #2
hal.canary
On 2014/04/09 14:11:52, djsollen wrote: LGTM, but you need some documentation of which environment variables ...
6 years, 8 months ago (2014-04-09 14:36:59 UTC) #3
djsollen
I can follow up with another CL that provides some documentation for the common android ...
6 years, 8 months ago (2014-04-09 14:40:25 UTC) #4
hal.canary
On 2014/04/09 14:40:25, djsollen wrote: > I can follow up with another CL that provides ...
6 years, 8 months ago (2014-04-09 14:43:41 UTC) #5
djsollen
The CQ bit was checked by djsollen@google.com
6 years, 8 months ago (2014-04-09 17:53:59 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://skia-tree-status.appspot.com/cq/djsollen@google.com/227673003/1
6 years, 8 months ago (2014-04-09 17:54:03 UTC) #7
commit-bot: I haz the power
6 years, 8 months ago (2014-04-09 18:57:46 UTC) #8
Message was sent while issue was closed.
Change committed as 14113

Powered by Google App Engine
This is Rietveld 408576698