enable developers to provide their own android toolchain

enable developers to provide their own android toolchain

Committed: http://code.google.com/p/skia/source/detail?r=14113

[hal.canary, 2014-04-09 14:36:59]

On 2014/04/09 14:11:52, djsollen wrote:

LGTM, but you need some documentation of which environment variables will effect
this script's behavior.

https://codereview.chromium.org/227673003/diff/1/platform_tools/android/bin/a...
File platform_tools/android/bin/android_setup.sh (right):

https://codereview.chromium.org/227673003/diff/1/platform_tools/android/bin/a...
platform_tools/android/bin/android_setup.sh:10: while (( "$#" )); do
if [[ "$1" == '--help' ]]; then
   usage; exit
fi

[djsollen, 2014-04-09 14:40:25]

I can follow up with another CL that provides some documentation for the common
android scripts.

https://codereview.chromium.org/227673003/diff/1/platform_tools/android/bin/a...
File platform_tools/android/bin/android_setup.sh (right):

https://codereview.chromium.org/227673003/diff/1/platform_tools/android/bin/a...
platform_tools/android/bin/android_setup.sh:10: while (( "$#" )); do
On 2014/04/09 14:37:00, Hal Canary wrote:
> if [[ "$1" == '--help' ]]; then
>    usage; exit
> fi

since this is a common include statement do you suggest that all apps that
include this file provide a useage() function?

[hal.canary, 2014-04-09 14:43:41]

On 2014/04/09 14:40:25, djsollen wrote:
> I can follow up with another CL that provides some documentation for the
common
> android scripts.
> 
>
https://codereview.chromium.org/227673003/diff/1/platform_tools/android/bin/a...
> File platform_tools/android/bin/android_setup.sh (right):
> 
>
https://codereview.chromium.org/227673003/diff/1/platform_tools/android/bin/a...
> platform_tools/android/bin/android_setup.sh:10: while (( "$#" )); do
> On 2014/04/09 14:37:00, Hal Canary wrote:
> > if [[ "$1" == '--help' ]]; then
> >    usage; exit
> > fi
> 
> since this is a common include statement do you suggest that all apps that
> include this file provide a useage() function?

Right.  You never call android_setup directly.  So that should be in the scripts
you do call.

[djsollen, 2014-04-09 17:53:59]

The CQ bit was checked by djsollen@google.com

[commit-bot: I haz the power, 2014-04-09 17:54:03]

CQ is trying da patch. Follow status at
https://skia-tree-status.appspot.com/cq/djsollen@google.com/227673003/1

[commit-bot: I haz the power, 2014-04-09 18:57:46]

Change committed as 14113