enable developers to provide their own android toolchain

platform_tools/android/bin/android_setup.sh

 #!/bin/bash
 #
 # android_setup.sh: Sets environment variables used by other Android scripts.
 
 # Fail-fast if anything in the script fails.
 set -e
 
 BUILDTYPE=${BUILDTYPE-Debug}
 
 while (( "$#" )); do

[hal.canary, 2014/04/09 14:37:00]

if [[ "$1" == '--help' ]]; then
   usage; exit
fi

[djsollen, 2014/04/09 14:40:25]

since this is a common include statement do you suggest that all apps that
include this file provide a useage() function?

   if [[ "$1" == "-d" ]]; then
     DEVICE_ID=$2
     shift
   elif [[ "$1" == "-s" ]]; then
     DEVICE_SERIAL="-s $2"
     shift
   elif [[ "$1" == "-t" ]]; then
     BUILDTYPE=$2
     shift
   elif [[ "$1" == "--release" ]]; then
@@ skipping 36 matching lines @@
 THIRD_PARTY_EXTERNAL_DIR=${SCRIPT_DIR}/../third_party/externals
 if [ ! -d "$THIRD_PARTY_EXTERNAL_DIR" ]; then
         echo ""
         echo "ERROR: Unable to find the required third_party dependencies needed to build."
         echo "       To fix this add the following line to your .gclient file and run 'gclient sync'"
         echo "        target_os = ['android']"
         echo ""
         exit 1;
 fi
 
-# Helper function to determine and download the toolchain that we will be using.
-setup_toolchain() {
-  API_LEVEL=14
-  NDK_REV=${NDK_REV-8e}
-  ANDROID_ARCH=${ANDROID_ARCH-arm}
-
-  TOOLCHAIN_DIR=${SCRIPT_DIR}/../toolchains
-  if [ $(uname) == "Darwin" ]; then
-    verbose "Using Mac toolchain."
-    TOOLCHAIN_TYPE=ndk-r$NDK_REV-$ANDROID_ARCH-mac_v$API_LEVEL
-  else
-    verbose "Using Linux toolchain."
-    TOOLCHAIN_TYPE=ndk-r$NDK_REV-$ANDROID_ARCH-linux_v$API_LEVEL
-  fi
-  exportVar ANDROID_TOOLCHAIN "${TOOLCHAIN_DIR}/${TOOLCHAIN_TYPE}/bin"
-
-  # if the toolchain doesn't exist on your machine then we need to fetch it
-  if [ ! -d "$ANDROID_TOOLCHAIN" ]; then
-    mkdir -p $TOOLCHAIN_DIR
-    # enter the toolchain directory then download, unpack, and remove the tarball
-    pushd $TOOLCHAIN_DIR
-    TARBALL=ndk-r$NDK_REV-v$API_LEVEL.tgz
-
-    ${SCRIPT_DIR}/download_toolchains.py \
-        http://chromium-skia-gm.commondatastorage.googleapis.com/android-toolchains/$TARBALL \
-        $TOOLCHAIN_DIR/$TARBALL
-    tar -xzf $TARBALL $TOOLCHAIN_TYPE
-    rm $TARBALL
-    popd
-  fi
-
-  if [ ! -d "$ANDROID_TOOLCHAIN" ]; then
-    echo "ERROR: unable to download/setup the required toolchain (${TOOLCHAIN_TYPE})"
-    return 1;
-  fi
-
-  verbose "Targeting NDK API $API_LEVEL for use on Android 4.0 (NDK Revision $NDK_REV) and above"
-
-  GCC=$(command ls $ANDROID_TOOLCHAIN/*-gcc | head -n1)
-  if [ -z "$GCC" ]; then
-    echo "ERROR: Could not find Android cross-compiler in: $ANDROID_TOOLCHAIN"
-    return 1
-  fi
-
-  # Remove the '-gcc' at the end to get the full toolchain prefix
-  ANDROID_TOOLCHAIN_PREFIX=${GCC%%-gcc}
-
-  CCACHE=${ANDROID_MAKE_CCACHE-$(which ccache || true)}
-
-  exportVar CC "$CCACHE $ANDROID_TOOLCHAIN_PREFIX-gcc"
-  exportVar CXX "$CCACHE $ANDROID_TOOLCHAIN_PREFIX-g++"
-  exportVar LINK "$CCACHE $ANDROID_TOOLCHAIN_PREFIX-gcc"
-
-  exportVar AR "$ANDROID_TOOLCHAIN_PREFIX-ar"
-  exportVar RANLIB "$ANDROID_TOOLCHAIN_PREFIX-ranlib"
-  exportVar OBJCOPY "$ANDROID_TOOLCHAIN_PREFIX-objcopy"
-  exportVar STRIP "$ANDROID_TOOLCHAIN_PREFIX-strip"
-
-  # Create symlinks for nm & readelf and add them to the path so that the ninja
-  # build uses them instead of attempting to use the one on the system.
-  # This is required to build using ninja on a Mac.
-  ln -sf $ANDROID_TOOLCHAIN_PREFIX-nm $ANDROID_TOOLCHAIN/nm
-  ln -sf $ANDROID_TOOLCHAIN_PREFIX-readelf $ANDROID_TOOLCHAIN/readelf
-  exportVar PATH $ANDROID_TOOLCHAIN:$PATH
-}
-
 # Helper function to configure the GYP defines to the appropriate values
 # based on the target device.
 setup_device() {
   DEFINES="OS=android"
   DEFINES="${DEFINES} host_os=$(uname -s | sed -e 's/Linux/linux/;s/Darwin/mac/')"
   DEFINES="${DEFINES} skia_os=android"
   DEFINES="${DEFINES} android_base=$(absPath ${SCRIPT_DIR}/..)"
   if [[ "$GYP_DEFINES" != *skia_shared_lib=* ]]; then
       DEFINES="${DEFINES} skia_shared_lib=1"
   fi
@@ skipping 58 matching lines @@
       ;;
     *)
       echo "ERROR: unknown device $TARGET_DEVICE"
       exit 1
       ;;
   esac
 
   verbose "The build is targeting the device: $TARGET_DEVICE"
   exportVar DEVICE_ID $TARGET_DEVICE
 
-  setup_toolchain
+  # setup the appropriate cross compiling toolchains
+  source $SCRIPT_DIR/utils/setup_toolchain.sh
 
   DEFINES="${DEFINES} android_toolchain=${TOOLCHAIN_TYPE}"
 
   exportVar GYP_DEFINES "$DEFINES $GYP_DEFINES"
   exportVar SKIA_OUT "out/config/android-${TARGET_DEVICE}"
 }
 
 # adb_pull_if_needed(android_src, host_dst)
 adb_pull_if_needed() {
 
@@ skipping 61 matching lines @@
       echo -n "$ANDROID_DST "
       $ADB $DEVICE_SERIAL push $HOST_SRC $ANDROID_DST
     fi
   else
     echo -n "$ANDROID_DST "
     $ADB $DEVICE_SERIAL push $HOST_SRC $ANDROID_DST
   fi
 }
 
 setup_device "${DEVICE_ID}"