Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(542)

Issue 2276713002: Remove Command.bind_to_tool. (Closed)

Created:
4 years, 4 months ago by qyearsley
Modified:
4 years, 4 months ago
Reviewers:
Dirk Pranke, dpranke
CC:
blink-reviews, chromium-reviews, Dirk Pranke
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove Command.bind_to_tool. This is a refactoring change that shouldn't affect behavior. Pros: - Removes a method; makes set-up of Command classes simpler. - Net decrease in lines of code. Cons: - Requires explicitly setting self._tool in all subclasses of AbstractRebaseliningCommand in the execute method. Committed: https://crrev.com/b6ddfced42442d4245d72103db8f0a4d28fd8ef1 Cr-Commit-Position: refs/heads/master@{#414163}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+19 lines, -37 lines) Patch
M third_party/WebKit/Tools/Scripts/webkitpy/tool/commands/abstract_local_server_command.py View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Tools/Scripts/webkitpy/tool/commands/analyze_baselines.py View 3 chunks +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Tools/Scripts/webkitpy/tool/commands/auto_rebaseline.py View 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/Tools/Scripts/webkitpy/tool/commands/command.py View 2 chunks +0 lines, -8 lines 0 comments Download
M third_party/WebKit/Tools/Scripts/webkitpy/tool/commands/command_test.py View 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/Tools/Scripts/webkitpy/tool/commands/help_command.py View 2 chunks +2 lines, -0 lines 0 comments Download
M third_party/WebKit/Tools/Scripts/webkitpy/tool/commands/optimize_baselines.py View 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/Tools/Scripts/webkitpy/tool/commands/pretty_diff.py View 1 chunk +2 lines, -0 lines 0 comments Download
M third_party/WebKit/Tools/Scripts/webkitpy/tool/commands/queries.py View 2 chunks +2 lines, -5 lines 0 comments Download
M third_party/WebKit/Tools/Scripts/webkitpy/tool/commands/queries_unittest.py View 4 chunks +0 lines, -4 lines 0 comments Download
M third_party/WebKit/Tools/Scripts/webkitpy/tool/commands/rebaseline.py View 6 chunks +6 lines, -0 lines 0 comments Download
M third_party/WebKit/Tools/Scripts/webkitpy/tool/commands/rebaseline_cl.py View 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/Tools/Scripts/webkitpy/tool/commands/rebaseline_unittest.py View 6 chunks +1 line, -7 lines 0 comments Download
M third_party/WebKit/Tools/Scripts/webkitpy/tool/webkit_patch.py View 1 chunk +0 lines, -4 lines 0 comments Download
M third_party/WebKit/Tools/Scripts/webkitpy/tool/webkit_patch_unittest.py View 1 chunk +0 lines, -5 lines 0 comments Download

Messages

Total messages: 15 (10 generated)
qyearsley
4 years, 4 months ago (2016-08-23 20:13:23 UTC) #3
Dirk Pranke
lgtm
4 years, 4 months ago (2016-08-24 18:29:25 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2276713002/1
4 years, 4 months ago (2016-08-24 21:54:30 UTC) #11
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 4 months ago (2016-08-24 22:00:50 UTC) #13
commit-bot: I haz the power
4 years, 4 months ago (2016-08-24 22:04:14 UTC) #15
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/b6ddfced42442d4245d72103db8f0a4d28fd8ef1
Cr-Commit-Position: refs/heads/master@{#414163}

Powered by Google App Engine
This is Rietveld 408576698