Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(137)

Unified Diff: third_party/WebKit/Tools/Scripts/webkitpy/tool/commands/queries.py

Issue 2276713002: Remove Command.bind_to_tool. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Tools/Scripts/webkitpy/tool/commands/queries.py
diff --git a/third_party/WebKit/Tools/Scripts/webkitpy/tool/commands/queries.py b/third_party/WebKit/Tools/Scripts/webkitpy/tool/commands/queries.py
index a34ee4b65d346b86c3cc83cca98da45c33cc7875..c797ed1e2c68b6e7f37e9c39c80d8f93df669fdd 100644
--- a/third_party/WebKit/Tools/Scripts/webkitpy/tool/commands/queries.py
+++ b/third_party/WebKit/Tools/Scripts/webkitpy/tool/commands/queries.py
@@ -110,7 +110,8 @@ class PrintExpectations(Command):
tests = set(default_port.tests(args))
for port_name in port_names:
- model = self._model(options, port_name, tests)
+ port = tool.port_factory.get(port_name, options)
+ model = TestExpectations(port, tests).model()
tests_to_print = self._filter_tests(options, model, tests)
lines = [model.get_expectation_line(test) for test in sorted(tests_to_print)]
if port_name != port_names[0]:
@@ -142,10 +143,6 @@ class PrintExpectations(Command):
output.append("%s" % line.to_string(None, include_modifiers, include_expectations, include_comment=False))
return output
- def _model(self, options, port_name, tests):
- port = self._tool.port_factory.get(port_name, options)
- return TestExpectations(port, tests).model()
-
class PrintBaselines(Command):
name = 'print-baselines'

Powered by Google App Engine
This is Rietveld 408576698