Fix DCHECK in MojoRendererService::SetPlaybackRate

Fix DCHECK in MojoRendererService::SetPlaybackRate

When MojoRendererService::OnError is called (e.g. for a decoder error),
state_ becomes STATE_ERROR, but the media player next pauses playback,
calling SetPlaybackRate(0), and hitting this DCHECK.

BUG=

Committed: https://crrev.com/0a535e9650355d14f383917aa85890f308f8f404
Cr-Commit-Position: refs/heads/master@{#414183}

[halliwell, 2016-08-24 16:57:47]

Description was changed from

==========
Fix DCHECK in MojoRendererService::SetPlaybackRate

When MojoRendererService::OnError is called (e.g. for a decoder error),
state_ becomes STATE_ERROR, but the media player next pauses playback,
calling SetPlaybackRate(0), and hitting this DCHECK.

BUG=
==========

to

==========
Fix DCHECK in MojoRendererService::SetPlaybackRate

When MojoRendererService::OnError is called (e.g. for a decoder error),
state_ becomes STATE_ERROR, but the media player next pauses playback,
calling SetPlaybackRate(0), and hitting this DCHECK.

BUG=
==========

[halliwell, 2016-08-24 16:57:47]

halliwell@chromium.org changed reviewers:
+ xhwang@chromium.org

[xhwang, 2016-08-24 17:08:14]

Thanks!!!

The change looks good. Is it possible to add a unittest for this? See
https://cs.chromium.org/chromium/src/media/mojo/clients/mojo_renderer_unittes...

[halliwell, 2016-08-24 20:54:12]

On 2016/08/24 17:08:14, xhwang (slow) wrote:
> Thanks!!!
> 
> The change looks good. Is it possible to add a unittest for this? See
>
https://cs.chromium.org/chromium/src/media/mojo/clients/mojo_renderer_unittes...

I added a test, PTAL :)

[xhwang, 2016-08-24 21:11:52]

Thanks! LGTM

[halliwell, 2016-08-24 21:13:17]

The CQ bit was checked by halliwell@chromium.org

[commit-bot: I haz the power, 2016-08-24 21:14:22]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-24 22:52:18]

Description was changed from

==========
Fix DCHECK in MojoRendererService::SetPlaybackRate

When MojoRendererService::OnError is called (e.g. for a decoder error),
state_ becomes STATE_ERROR, but the media player next pauses playback,
calling SetPlaybackRate(0), and hitting this DCHECK.

BUG=
==========

to

==========
Fix DCHECK in MojoRendererService::SetPlaybackRate

When MojoRendererService::OnError is called (e.g. for a decoder error),
state_ becomes STATE_ERROR, but the media player next pauses playback,
calling SetPlaybackRate(0), and hitting this DCHECK.

BUG=
==========

[commit-bot: I haz the power, 2016-08-24 22:52:19]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-08-24 22:53:34]

Description was changed from

==========
Fix DCHECK in MojoRendererService::SetPlaybackRate

When MojoRendererService::OnError is called (e.g. for a decoder error),
state_ becomes STATE_ERROR, but the media player next pauses playback,
calling SetPlaybackRate(0), and hitting this DCHECK.

BUG=
==========

to

==========
Fix DCHECK in MojoRendererService::SetPlaybackRate

When MojoRendererService::OnError is called (e.g. for a decoder error),
state_ becomes STATE_ERROR, but the media player next pauses playback,
calling SetPlaybackRate(0), and hitting this DCHECK.

BUG=

Committed: https://crrev.com/0a535e9650355d14f383917aa85890f308f8f404
Cr-Commit-Position: refs/heads/master@{#414183}
==========

[commit-bot: I haz the power, 2016-08-24 22:53:35]

Patchset 2 (id:??) landed as
https://crrev.com/0a535e9650355d14f383917aa85890f308f8f404
Cr-Commit-Position: refs/heads/master@{#414183}