media/mojo/services/mojo_renderer_service.cc - Issue 2276663003: Fix DCHECK in MojoRendererService::SetPlaybackRate

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: media/mojo/services/mojo_renderer_service.cc

Issue 2276663003: Fix DCHECK in MojoRendererService::SetPlaybackRate (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Add unit test Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: media/mojo/services/mojo_renderer_service.cc

diff --git a/media/mojo/services/mojo_renderer_service.cc b/media/mojo/services/mojo_renderer_service.cc

index f2079ea8bb429f6e47437f2cc4e34912a5e82832..96ca86ed93a6e1e4c70f87a8563f4508da88eaae 100644

--- a/media/mojo/services/mojo_renderer_service.cc

+++ b/media/mojo/services/mojo_renderer_service.cc

@@ -80,7 +80,7 @@ void MojoRendererService::StartPlayingFrom(base::TimeDelta time_delta) {

void MojoRendererService::SetPlaybackRate(double playback_rate) {

DVLOG(2) << __FUNCTION__ << ": " << playback_rate;

- DCHECK_EQ(state_, STATE_PLAYING);

+ DCHECK(state_ == STATE_PLAYING || state_ == STATE_ERROR);

renderer_->SetPlaybackRate(playback_rate);

}

« no previous file with comments | « media/mojo/clients/mojo_renderer_unittest.cc ('k') | no next file » | no next file with comments »