combine setRectFan and mapRect

combine setRectFan and mapRect

BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2276603002

Committed: https://skia.googlesource.com/skia/+/6a88206b2ece8b64534c87fca156e5fe161f884e

[reed1, 2016-08-23 17:39:22]

Description was changed from

==========
combine setRectFan and mapRect

BUG=skia:
==========

to

==========
combine setRectFan and mapRect

BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2276603002
==========

[reed1, 2016-08-23 17:40:02]

reed@google.com changed reviewers:
+ bsalomon@google.com, robertphillips@google.com

[reed1, 2016-08-23 17:40:06]

The CQ bit was checked by reed@google.com

[commit-bot: I haz the power, 2016-08-23 17:40:11]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-23 17:40:12]

Note for Reviewers:
The CQ is waiting for an approval.
If you believe that the CL is not ready yet, or if you would like to L-G-T-M
with comments then please uncheck the CQ checkbox.

Waiting for LGTM from valid reviewer(s) till 2016-08-23 23:40 UTC

[robertphillips, 2016-08-23 19:50:15]

The CQ bit was unchecked by robertphillips@google.com

[robertphillips, 2016-08-23 19:50:19]

lgtm

https://codereview.chromium.org/2276603002/diff/1/src/core/SkMatrixPriv.h
File src/core/SkMatrixPriv.h (right):

https://codereview.chromium.org/2276603002/diff/1/src/core/SkMatrixPriv.h#new...
src/core/SkMatrixPriv.h:68: 
Would the mx, rect, quad parameter order be more pleasing ?

[bsalomon, 2016-08-23 20:15:40]

https://codereview.chromium.org/2276603002/diff/1/src/core/SkMatrixPriv.h
File src/core/SkMatrixPriv.h (right):

https://codereview.chromium.org/2276603002/diff/1/src/core/SkMatrixPriv.h#new...
src/core/SkMatrixPriv.h:68: 
On 2016/08/23 19:50:19, robertphillips wrote:
> Would the mx, rect, quad parameter order be more pleasing ? 

I'd be in favor of any order that had the two input params next to each other.

[reed1, 2016-08-24 11:01:09]

The CQ bit was checked by reed@google.com

[reed1, 2016-08-24 11:01:10]

The patchset sent to the CQ was uploaded after l-g-t-m from
robertphillips@google.com
Link to the patchset: https://codereview.chromium.org/2276603002/#ps20001
(title: "rearrange parameter order")

[commit-bot: I haz the power, 2016-08-24 11:01:15]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-24 11:22:11]

Description was changed from

==========
combine setRectFan and mapRect

BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2276603002
==========

to

==========
combine setRectFan and mapRect

BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2276603002

Committed:
https://skia.googlesource.com/skia/+/6a88206b2ece8b64534c87fca156e5fe161f884e
==========

[commit-bot: I haz the power, 2016-08-24 11:22:12]

Committed patchset #2 (id:20001) as
https://skia.googlesource.com/skia/+/6a88206b2ece8b64534c87fca156e5fe161f884e