[NaCl SDK] Fix PNACL for debugging.

[NaCl SDK] Fix PNACL for debugging.

make TOOLCHAIN=pnacl DEBUG is broken.

This CL redirects all nacl-gdb calls to the gdb in newlib.
For DEBUG builds, the EXECUTABLES=*.nexe
For RELESE builds, the EXECUTABLES=*.pexe

This creates a dependency on the *.bc -> *.nexe translation and
feeds the output the the NMF generator, making the debugging case
essitial the same as newlib.

For RELEASE configs, we build a finalized .pexe and load that.

common.js now only use application-pnacl for release versions.

BUG=270745
R=sbc@chromium.org

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=216888

[noelallen1, 2013-08-09 23:34:01]

ptal

[Sam Clegg, 2013-08-10 00:54:01]

lgtm

https://codereview.chromium.org/22766003/diff/1/native_client_sdk/src/tools/c...
File native_client_sdk/src/tools/common.mk (right):

https://codereview.chromium.org/22766003/diff/1/native_client_sdk/src/tools/c...
native_client_sdk/src/tools/common.mk:480: # name gdb for everyone ?!?!?
/name/same/.   Perhaps a better comment?  Perhaps TODO() ship just a single
version of gdb outside the toolchain folder, or use symlinks to an outside one.

https://codereview.chromium.org/22766003/diff/1/native_client_sdk/src/tools/n...
File native_client_sdk/src/tools/nacl_llvm.mk (right):

https://codereview.chromium.org/22766003/diff/1/native_client_sdk/src/tools/n...
native_client_sdk/src/tools/nacl_llvm.mk:1: # Copyright (c) 2012 The Chromium
Authors.   All rights reserved.
Was that deliberate?  3 spaces?

https://codereview.chromium.org/22766003/diff/1/native_client_sdk/src/tools/n...
native_client_sdk/src/tools/nacl_llvm.mk:21: # if you want to debug, do not use
PEXE, use BC
You mean "use NEXE"?  

This comment could be filled out a bit, or perhaps moved down to where translate
is used.

https://codereview.chromium.org/22766003/diff/1/native_client_sdk/src/tools/n...
native_client_sdk/src/tools/nacl_llvm.mk:158: 
This variable seems to be specified twice.

Does this take into account?

[noelallen1, 2013-08-10 19:08:49]

https://codereview.chromium.org/22766003/diff/1/native_client_sdk/src/tools/c...
File native_client_sdk/src/tools/common.mk (right):

https://codereview.chromium.org/22766003/diff/1/native_client_sdk/src/tools/c...
native_client_sdk/src/tools/common.mk:480: # name gdb for everyone ?!?!?
On 2013/08/10 00:54:01, Sam Clegg wrote:
> /name/same/.   Perhaps a better comment?  Perhaps TODO() ship just a single
> version of gdb outside the toolchain folder, or use symlinks to an outside
one.

Adding a bug to fix this.
BUG=271183

https://codereview.chromium.org/22766003/diff/1/native_client_sdk/src/tools/n...
File native_client_sdk/src/tools/nacl_llvm.mk (right):

https://codereview.chromium.org/22766003/diff/1/native_client_sdk/src/tools/n...
native_client_sdk/src/tools/nacl_llvm.mk:21: # if you want to debug, do not use
PEXE, use BC
On 2013/08/10 00:54:01, Sam Clegg wrote:
> You mean "use NEXE"?  
> 
> This comment could be filled out a bit, or perhaps moved down to where
translate
> is used.

Done.

https://codereview.chromium.org/22766003/diff/1/native_client_sdk/src/tools/n...
native_client_sdk/src/tools/nacl_llvm.mk:158: 
On 2013/08/10 00:54:01, Sam Clegg wrote:
> This variable seems to be specified twice.
> 
> Does this take into account?

Done.

[noelallen1, 2013-08-10 22:59:42]

Committed patchset #3 manually as r216888.